Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tracking commits pushed to branch (core) #601

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

rajku-dev
Copy link
Contributor

@rajku-dev rajku-dev commented Jan 9, 2025

Fixes #373

Copy link

netlify bot commented Jan 9, 2025

👷 Deploy request for leaderboard-develop pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 1db1d86

@rajku-dev
Copy link
Contributor Author

rajku-dev commented Jan 10, 2025

How can i test the scraper for debugging? i can't run it on local machine?
@rithviknishad

@rajku-dev
Copy link
Contributor Author

rajku-dev commented Jan 10, 2025

There were two directions for each fetched Fork

  1. Fetch all its events and filter the PushEvent (REST event endpoint)
  2. Fetch all its branches and get their commit history (GraphQL)

i went with the second one for now.

@rithviknishad
Copy link
Member

Not a fan of N+1 approach. If this was deployed for a much bigger github org, which has too many forks, fetching commit history of each fork's branches might go off the limits pretty quickly.

Let's do a 2 part PR. Let's first get the org's repo commits tracked first. We can figure out something for the fork's. We only ideally care about commits pushed directly to default branch and commits pushed to PR branches alone.

@rajku-dev rajku-dev changed the title Add support for tracking commits pushed to branch Add support for tracking commits pushed to branch (core) Jan 10, 2025
@rajku-dev
Copy link
Contributor Author

rajku-dev commented Jan 10, 2025

Not a fan of N+1 approach. If this was deployed for a much bigger github org, which has too many forks, fetching commit history of each fork's branches might go off the limits pretty quickly.

Let's do a 2 part PR. Let's first get the org's repo commits tracked first. We can figure out something for the fork's. We only ideally care about commits pushed directly to default branch and commits pushed to PR branches alone.

I do agree with you, Please check this out #602 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for tracking commits pushed directly to branch
2 participants