FileIdCache: Allow flexible handle instead of direct borrow for file ids #664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I suggest changing the return type of the
cached_file_id
method in theFileIdCache
fromOption<&FileId>
toOption<impl Deref<Target=FileId>>;
(breaking change)This allows trait consumers to choose more freely how to return the FileId.
In a FileIdCache implementation I had to do I was required to return a owned copy of the file id.
The changed return type allows eg. a Cow::Owned or any other new-type implementation that dereferences to a FileId.
This is now doable with the recent MSRV raise to 1.77.