fix(blog): fix pubdate of upcoming-cve-for-eol-versions #7403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regressed in 8e5ef67 . this patch bring back the `T16` part to make it a valid Date string Signed-off-by: Masataka Yakura <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
apps/site/pages/en/blog/vulnerability/upcoming-cve-for-eol-versions.md
Outdated
Show resolved
Hide resolved
RafaelGSS
approved these changes
Jan 13, 2025
|
proposing a fast track on this small fix |
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
AugustinMauroy
approved these changes
Jan 13, 2025
|
this failure it interesting because it explicitly mentions an unparseable date. |
But why it's pass on windows ? |
aymen94
approved these changes
Jan 16, 2025
mikeesto
reviewed
Jan 16, 2025
github-actions
bot
removed
the
github_actions:pull-request
github-actions
bot
removed
the
github_actions:pull-request
|
Wait ??? On my safari console I got "invalid date" 
|
apps/site/pages/en/blog/vulnerability/upcoming-cve-for-eol-versions.md
Outdated
Show resolved
Hide resolved
…sions.md Co-authored-by: Augustin Mauroy <[email protected]> Signed-off-by: Brian Muenzenmeyer <[email protected]>
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch fixes the date of the Node.js — Upcoming CVE for End-of-Life Node.js Versions blog post by bringing back the
T16part to make it a valid Date string.Regressed in 8e5ef67 .
Validation
Related Issues
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.