-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix styles of the expandable TOC #56755
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
jasnell
approved these changes
Jan 24, 2025
aduh95
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jan 24, 2025
AugustinMauroy
approved these changes
Jan 25, 2025
UlisesGascon
approved these changes
Jan 25, 2025
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 25, 2025
bmuenzenmeyer
approved these changes
Jan 26, 2025
@aduh95 would you mind backporting these to the api-docs-tooling repo? Otherwise I can do'em! |
nvm, making a PR myself. |
ovflowd
approved these changes
Jan 26, 2025
lpinca
approved these changes
Jan 26, 2025
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 26, 2025
Landed in 43daa9b |
aduh95
added a commit
to nodejs/api-docs-tooling
that referenced
this pull request
Jan 27, 2025
PR-URL: nodejs/node#56755 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
added a commit
to nodejs/api-docs-tooling
that referenced
this pull request
Jan 27, 2025
PR-URL: nodejs/node#56755 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current CSS uses
::before
to build custom list markers, which causes them to appear underlined. This PR undoes that to use plain old list marker instead.Before
After