events: refactored emit to improve performance #56741
Open
+24
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored error handling logic for clarity and efficiency. Streamlined error inspection and stringification process. Enhanced stack trace handling with minimal performance overhead. Simplified listener iteration and result handling in emit method. Fixes: nodejs#53056 Signed-off-by: KUNAL KUMAR <[email protected]>
nodejs-github-bot
added
events
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56741 +/- ##
==========================================
- Coverage 89.21% 89.20% -0.01%
==========================================
Files 662 662
Lines 191968 191958 -10
Branches 36955 36952 -3
==========================================
- Hits 171269 171242 -27
- Misses 13535 13552 +17
Partials 7164 7164
|
KunalKumar-1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes improve the overall efficiency and maintainability of the emit method
Fixes: #53056