Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x] test: skip test-buffer-tostring-range on smartos #56727

Open
wants to merge 1 commit into
base: v20.x-staging
Choose a base branch
from
Open

[v20.x] test: skip test-buffer-tostring-range on smartos #56727

wants to merge 1 commit into from

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Jan 23, 2025 •
edited by richardlau
Loading

Unblocks v20 release #56699

Refs: #56726

@nodejs/platform-smartos

@nodejs/releasers

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 23, 2025
@marco-ippolito marco-ippolito changed the title test: mark test-buffer-tostring-range as flaky test: mark test-buffer-tostring-range as flaky Jan 23, 2025
@marco-ippolito marco-ippolito mentioned this pull request Jan 23, 2025
Open
@marco-ippolito marco-ippolito added lts-watch-v20.x PRs that may need to be released in v20.x request-ci Add this label to start a Jenkins CI on a PR. labels Jan 23, 2025
@lpinca
Copy link
Member

lpinca commented Jan 23, 2025 •
edited
Loading

Please remove Fixes: from the issue description, otherwise the tracking issue will be closed when this lands.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64641/

@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (d978610) to head (2588b7d).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56727   +/-   ##
=======================================
  Coverage   89.21%   89.21%           
=======================================
  Files         662      662           
  Lines      191945   191945           
  Branches    36948    36945    -3     
=======================================
+ Hits       171238   171246    +8     
+ Misses      13549    13541    -8     
  Partials     7158     7158

see 23 files with indirect coverage changes

aduh95
aduh95 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this land on other release lines than 20.x? Looking at daily, it's failing only on 20.x

joyeecheung
joyeecheung approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think on v20.x it's not flaky, it's just 100% failure...so if you plan to backport it to v20.x it might be better to just use SKIP there.

@joyeecheung
Copy link
Member

joyeecheung commented Jan 23, 2025 •
edited
Loading

Actually, no, this is not flaky on the main branch, it's only 100% failure on v20.x. See https://github.com/nodejs/reliability/blob/main/reports/2025-01-23.md - both PRs referenced are targetting v20.x

@marco-ippolito
Copy link
Member Author

I'm move this to v20.x only

@marco-ippolito marco-ippolito requested a review from a team as a code owner January 23, 2025 14:45
@marco-ippolito marco-ippolito changed the base branch from main to v20.x-staging January 23, 2025 14:45
@marco-ippolito marco-ippolito changed the title test: mark test-buffer-tostring-range as flaky [v20.x] test: mark test-buffer-tostring-range as flaky Jan 23, 2025
@marco-ippolito marco-ippolito added v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. and removed lts-watch-v20.x PRs that may need to be released in v20.x labels Jan 23, 2025
@aduh95 aduh95 mentioned this pull request Jan 23, 2025
Closed
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64651/

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64655/

@marco-ippolito marco-ippolito changed the title [v20.x] test: mark test-buffer-tostring-range as flaky [v20.x] test: skip test-buffer-tostring-range on smartos Jan 23, 2025
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64659/

@marco-ippolito marco-ippolito force-pushed the fix/smart-os branch 2 times, most recently from c7435d1 to c0116be Compare January 24, 2025 12:51
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64700/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64721/

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64727/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64737/

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Jan 25, 2025 •
edited
Loading

The branch (v20.x-staging) seems to fail consistently on windows for permission model @RafaelGSS
https://ci.nodejs.org/job/node-test-binary-windows-js-suites/32273/RUN_SUBSET=1,nodes=win11-arm64-COMPILED_BY-vs2019-arm64/console

07:42:36 not ok 598 parallel/test-permission-fs-write
07:42:36   ---
07:42:36   duration_ms: 464.99100
07:42:36   severity: fail
07:42:36   exitcode: 1
07:42:36   stack: |-
07:42:36     node:assert:90
07:42:36       throw new AssertionError(obj);
07:42:36       ^
07:42:36     
07:42:36     AssertionError [ERR_ASSERTION]: node:assert:377
07:42:36     
07:42:36           throw err;
07:42:36     
07:42:36           ^
07:42:36     
07:42:36     
07:42:36     
07:42:36     AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
07:42:36     
07:42:36     + actual - expected
07:42:36     
07:42:36     
07:42:36     
07:42:36       Comparison {
07:42:36     
07:42:36         code: 'ERR_ACCESS_DENIED',
07:42:36     
07:42:36         permission: 'FileSystemWrite',
07:42:36     
07:42:36     +   resource: 'd:\\workspace\\node-test-binary-windows-js-suites\\node\\test\\fixtures\\permission\\deny\\protected-file.md'
07:42:36     
07:42:36     -   resource: '\\\\?\\d:\\workspace\\node-test-binary-windows-js-suites\\node\\test\\fixtures\\permission\\deny\\protected-file.md'
07:42:36     
07:42:36       }
07:42:36     
07:42:36         at d:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:727:12
07:42:36     
07:42:36         at d:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:474:15
07:42:36     
07:42:36         at node:fs:2327:7
07:42:36     
07:42:36         at FSReqCallback.oncomplete (node:fs:188:23)
07:42:36     
07:42:36         at Object.open (node:fs:558:11)
07:42:36     
07:42:36         at Object.writeFile (node:fs:2325:6)
07:42:36     
07:42:36         at Object.<anonymous> (d:\workspace\node-test-binary-windows-js-suites\node\test\fixtures\permission\fs-write.js:38:6)
07:42:36     
07:42:36         at Module._compile (node:internal/modules/cjs/loader:1469:14)
07:42:36     
07:42:36         at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
07:42:36     
07:42:36         at Module.load (node:internal/modules/cjs/loader:1288:32) {
07:42:36     
07:42:36       generatedMessage: true,
07:42:36     
07:42:36       code: 'ERR_ASSERTION',
07:42:36     
07:42:36       actual: Error: Access to this API has been restricted
07:42:36     
07:42:36           at Object.open (node:fs:558:11)
07:42:36     
07:42:36           at Object.writeFile (node:fs:2325:6)
07:42:36     
07:42:36           at Object.<anonymous> (d:\workspace\node-test-binary-windows-js-suites\node\test\fixtures\permission\fs-write.js:38:6)
07:42:36     
07:42:36           at Module._compile (node:internal/modules/cjs/loader:1469:14)
07:42:36     
07:42:36           at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
07:42:36     
07:42:36           at Module.load (node:internal/modules/cjs/loader:1288:32)
07:42:36     
07:42:36           at Module._load (node:internal/modules/cjs/loader:1104:12)
07:42:36     
07:42:36           at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:173:12)
07:42:36     
07:42:36           at node:internal/main/run_main_module:28:49 {
07:42:36     
07:42:36         code: 'ERR_ACCESS_DENIED',
07:42:36     
07:42:36         permission: 'FileSystemWrite',
07:42:36     
07:42:36         resource: 'd:\\workspace\\node-test-binary-windows-js-suites\\node\\test\\fixtures\\permission\\deny\\protected-file.md'
07:42:36     
07:42:36       },
07:42:36     
07:42:36       expected: {
07:42:36     
07:42:36         code: 'ERR_ACCESS_DENIED',
07:42:36     
07:42:36         permission: 'FileSystemWrite',
07:42:36     
07:42:36         resource: '\\\\?\\d:\\workspace\\node-test-binary-windows-js-suites\\node\\test\\fixtures\\permission\\deny\\protected-file.md'
07:42:36     
07:42:36       },
07:42:36     
07:42:36       operator: 'throws'
07:42:36     
07:42:36     }
07:42:36     
07:42:36     
07:42:36     
07:42:36     Node.js v20.18.3-pre
07:42:36     
07:42:36     
07:42:36     
07:42:36     1 !== 0
07:42:36     
07:42:36         at Object.<anonymous> (d:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-permission-fs-write.js:44:10)
07:42:36         at Module._compile (node:internal/modules/cjs/loader:1469:14)
07:42:36         at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
07:42:36         at Module.load (node:internal/modules/cjs/loader:1288:32)
07:42:36         at Module._load (node:internal/modules/cjs/loader:1104:12)
07:42:36         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:173:12)
07:42:36         at node:internal/main/run_main_module:28:49 {
07:42:36       generatedMessage: false,
07:42:36       code: 'ERR_ASSERTION',
07:42:36       actual: 1,
07:42:36       expected: 0,
07:42:36       operator: 'strictEqual'
07:42:36     }
07:42:36     
07:42:36     Node.js v20.18.3-pre

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64743/

@RafaelGSS
Copy link
Member

@marco-ippolito I'll fix it Monday. Sorry about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@jclulow jclulow jclulow left review comments

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@marco-ippolito @lpinca @nodejs-github-bot @joyeecheung @RafaelGSS @jclulow @richardlau @aduh95