Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatar component with unit tests (merged because of a misconduct) #13

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

Avatar component with unit tests (merged because of a misconduct) #13

wants to merge 38 commits into from

Conversation

ryanvvalkenhoef
Copy link
Contributor

No description provided.

@ryanvvalkenhoef
Created avatar-component
b8e39b5
@ryanvvalkenhoef
Write styles for the avatar-container and avatar-icon
36ba545
@ryanvvalkenhoef
Finished avatar story and component
416c136
@ryanvvalkenhoef
Changed example to kernteam
71b23e3
@ryanvvalkenhoef
Created react-component for Avatar
756677a
@ryanvvalkenhoef
Made react-component without design-tokens
82a4fad
@ryanvvalkenhoef
Refactored avatar react-component
88b95b1
@ryanvvalkenhoef
Created react-component story and web-component story
768aa6d
@ryanvvalkenhoef
Moved stencil web-components into newly added components folder
fdf2da8
@ryanvvalkenhoef
Installed @jest/globals again and removed avatar from dist folder
a8707c1
@ryanvvalkenhoef
Declared prettier module
fd8bde2
@ryanvvalkenhoef
Finished Avatar web-component and fixed errors in stories
5bab70f
@ryanvvalkenhoef
Change properties of avatar web-component
819620f
@ryanvvalkenhoef
Created tests for react-component
ce20979
@ryanvvalkenhoef
Added types to tsconfig.json, excluded test files and removed tsconfi…
844c06d 
…g.test.json
@ryanvvalkenhoef
Added setupFilesAfterEnv
ed7e262
@ryanvvalkenhoef
Updated pnpm-lock.yaml
3312e93
@ryanvvalkenhoef
Created avatar-component
e91dc3b
@ryanvvalkenhoef
Write styles for the avatar-container and avatar-icon
97e7573
@ryanvvalkenhoef
Finished avatar story and component
e47175d
@ryanvvalkenhoef
Changed example to kernteam
2d87ad6
@ryanvvalkenhoef
Created react-component for Avatar
0597086
@ryanvvalkenhoef
Made react-component without design-tokens
cc88303
@ryanvvalkenhoef
Refactored avatar react-component
88dd7ba
@ryanvvalkenhoef
Created react-component story and web-component story
c0dff5d
@ryanvvalkenhoef
Moved stencil web-components into newly added components folder
cd6b155
@ryanvvalkenhoef
Installed @jest/globals again and removed avatar from dist folder
b743ddd
@ryanvvalkenhoef
Declared prettier module
564fc9d
@ryanvvalkenhoef
Finished Avatar web-component and fixed errors in stories
a96e141
@ryanvvalkenhoef
Change properties of avatar web-component
b614140
@ryanvvalkenhoef ryanvvalkenhoef changed the title Avatar component with unit tests (reset because of a misconduct) Avatar component with unit tests (merged because of a misconduct) Jan 3, 2024
@ryanvvalkenhoef ryanvvalkenhoef marked this pull request as draft January 3, 2024 16:00
@ryanvvalkenhoef ryanvvalkenhoef marked this pull request as ready for review January 3, 2024 16:05
Robbert
Robbert reviewed Jan 4, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
packages/components-css/avatar/README.md Outdated Show resolved Hide resolved
packages/components-css/avatar/index.scss Outdated Show resolved Hide resolved
packages/components-react/package.json Outdated Show resolved Hide resolved
packages/components-react/src/Avatar.test.tsx Show resolved Hide resolved
packages/storybook/config/preview.tsx Outdated Show resolved Hide resolved
packages/storybook/package.json Show resolved Hide resolved
packages/storybook/src/avatar/css-avatar.stories.tsx Outdated Show resolved Hide resolved
packages/web-components-stencil/package.json Outdated Show resolved Hide resolved
packages/web-components-stencil/src/components/avatar/stencil.tsx Outdated Show resolved Hide resolved
Robbert
Robbert requested changes Jan 4, 2024
View reviewed changes
Copy link
Member

@Robbert Robbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robbert Robbert Awaiting requested review from Robbert

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanvvalkenhoef @Robbert