Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Www denhaag nl/reduce unused css #1659

Merged
merged 70 commits into from
Jan 9, 2025
Merged

Www denhaag nl/reduce unused css #1659

merged 70 commits into from
Jan 9, 2025

Conversation

paulAcato
Copy link
Contributor

Closing issues

paulAcato and others added 30 commits November 11, 2024 08:51
@paulAcato
docs(code of conduct): test commit
c815140
@paulAcato
style: remove unused open-forms tokens
c432701
@paulAcato
style: replace hsl() with hex, due to the issue of heavier to render
8134349
@paulAcato
style: reduce duplicate variables, by renaming spacing-block and -inl…
95ddaf4 
…ine variables to just spacing
@paulAcato
style: replace another batch of -block to default and start cleanup t…
badfb4a 
…he accordion
@paulAcato
style(accordion): reduced the accordion amounts to 2
f874cf9
@paulAcato
style(accordion): no accordion tokens left
f2e72b4
@paulAcato
style(anchor-collapse): remove all custom css variables that are set … (
b68dc01 
#1581)
@paulAcato
style(authenticaion-block): reduce css tokens
60b55fa
@paulAcato
style(badge-counter): set css variariable which already exists
70eb019
@marcoderover
Www denhaag nl/reduce unused css alert (#1587)
3e73b59 
Set fallback for the CSS variables and reduce almost all the alert
tokens.
@paulAcato
style(anchor-navigation): reduce the amount of css variables (#1582)
d604e8a
@paulAcato
style(blockquote): reduce all unecassary set tokens (#1585)
475cf41
@paulAcato
style(article-meta): reduce css tokens (#1583)
27742cb
@paulAcato
Www denhaag nl/reduce unused css button group (#1591)
9d805e6
@marcoderover @paulAcato
style(button): reduce tokens (#1592)
b7b7ebe 
Hey Paul, deze moet even heel goed gecheckt worden.

Deze had ik laten staan omdat er die calc() functies in zitten die het
gebruiken.
Als zou medium ook nog aangepast kunnen worden naar default? Ik vond het
een beetje een lastige.

```
 "medium-size": {
    "padding-block": { "value": "{denhaag.space.xs}" },
    "padding-inline": { "value": "{denhaag.space.md}" }
},
```

---------

Co-authored-by: Paul van Impelen <[email protected]>
@paulAcato
style(cards): cleanup css tokens of all card components (#1593)
a5503d5
@paulAcato
style(breadcrumb): reduce css tokens + fix console errors (#1590)
2842548
@marcoderover
style(cta download): reduce tokens (#1595)
b276617
@paulAcato
style(conditions): reduced tokens to 0 (#1594)
4d59ba8
@marcoderover
Www denhaag .nl/reduce unused css cta event (#1597)
02db0a8
@paulAcato
Www denhaag nl/reduce unused css datepicker (#1596)
591a062
@paulAcato
style(description-list): reduced tokens to 0 (#1598)
9e2d20d 
Variabele die voor zowel `-start` als `-end` altijd gelijk waren heb ik
naar 1 variabel gezet.
@marcoderover
style(cta link): reduce tokens (#1600)
20c197d
@marcoderover
Www denhaag nl/reduce unused css divider (#1602)
bb7133d
@marcoderover
style(cta image content): reduce tokens (#1599)
01686fe
@paulAcato
chore(card-case): remove partial (#1605)
0809b6b 
13 november 2024 om 16:46 heeft Tom bevestigd dat dit component komt te
vervallen.
@paulAcato
style(highlighted-links): reduce tokens and css (#1607)
6db0e34
@marcoderover
style(event date): reduce tokens (#1606)
ddc6f19
@marcoderover
style(floating contact): reduce tokens (#1608)
9a85933 
Dit waren er een hoop, pls extra goed checken 🙏
paulAcato and others added 21 commits December 12, 2024 15:03
@paulAcato
style(image-banner): apply own feedback
5cb7174
@marcoderover
style(inline carousel): reduce tokens (#1627)
3543f4a 
For the sake of sanity and time heb ik hier niet alles overschreven. Ik
weet dat we display, position, top, left.. enz.. beter zonder variabelen
kunnen schrijven. Maar het is hier zoveel overbodig. In general zou ik
zeggen dat voor zulke elementen alleen kleuren en teksten gewijzigd
mogen worden. Lijkt me gewoon niet handig dat je sizes van een carousel
kan aanpassen.
@marcoderover
style(link): reduce tokens (#1628)
67b0d3b
@marcoderover
style(image): reduce tokens (#1626)
20614d1
@marcoderover
style(illustrated list block): reduce tokens (#1624)
a98dea6
@marcoderover
style(procedure): reduce tokens (#1640)
27fab5e
@paulAcato
feat(icons): set icons in links 20x20 and fix multiple issues (#1641)
4303e5e 
Goed controleren graag (door o.a. eerst www-denhaag-nl/reduce-unused~
binnen te halen en daarna deze branch);


En om issues te voorkomen: 
1. `git checkout www-denhaag-nl/reduce-unused-css; git pull; yarn run
build; yarn storybook`
2. `git checkout
www-denhaag-nl/reduce-unused-css--check-multiple-components; git pull;
yarn run build; yarn storybook`


*Hoe/wat/waarom*
1. Icons waren op meerdere manieren gedefineerd;
2. Icons in links moesten 20x20 worden i.p.v. gekke formaten;
3. Code in links (en andere blocks waarin links gebruikt worden)
nagelopen;
4. Wrapper van denhaag-link__icon weggehaald, zorgde puur voor
problemen, voegde niks toe wat de <SVG> zelf niet kan.
@paulAcato
Www denhaag nl/reduce unused css event icons (#1643)
3c2c5dd 
- Heel veel unknown-html van mdx gefixed;
- Aantal iconen gelijk getrokken aan denhaag-icon;
- Die specifieke iconen ook 24x24 gemaakt conform icon-sheet;
- Specifieke CSS aangepast
@marcoderover
style(process-steps): reduce tokens (#1642)
db55ffd 
Deze is ook beetje tricky omdat tokens in meerdere files gebruikt worden
en er werden een paar tokens gebruikt die binnen de tokens verwezen naar
een ander token.
@paulAcato
Www denhaag nl/reduce unused css event icons (#1644)
291d2b7 
<!--

IMPORTANT: Please do not create a Pull Request without creating an issue
first.
Any change needs to be discussed before proceeding. Failure to do so may
result in the rejection of the pull request.

Explain the details for making this change. What existing problem does
the pull request solve?
Example: When "Adding a function to do X", explain why it is necessary
to have a way to do X.

-->

**Closing issues**

<!-- Put `closes #XXXX` in your comment to auto-close the issue that
your PR fixes (if such). -->
@marcoderover
style(tabs): reduce tokens (#1651)
43e0c0c
@marcoderover
style(sidenav): reduce tokens (#1648)
c88a76e
@marcoderover
style(responsive content): reduce tokens (#1647)
125e536
@marcoderover
style(timeline): reduce tokens (#1652)
b1ffd04
@marcoderover
style(table): reduce tokens (#1650)
a9993fe
@paulAcato
style(global): static valeus to variables
55f444c
@paulAcato
style(form-*): reduce tokens
29613e2
@paulAcato
Www denhaag nl/reduce unused css reduce hardcoded fallbacks (#1654)
7e937e3 
<!--

IMPORTANT: Please do not create a Pull Request without creating an issue
first.
Any change needs to be discussed before proceeding. Failure to do so may
result in the rejection of the pull request.

Explain the details for making this change. What existing problem does
the pull request solve?
Example: When "Adding a function to do X", explain why it is necessary
to have a way to do X.

-->

**Closing issues**

<!-- Put `closes #XXXX` in your comment to auto-close the issue that
your PR fixes (if such). -->
@paulAcato
style(focus-border): multiple focus borders to the default
0b8ff52
@paulAcato
Merge branch 'www-denhaag-nl/reduce-unused-css--reduce-hardcoded-fall…
e64a048 
…backs' into www-denhaag-nl/reduce-unused-css
@marcoderover
style(radio): reduce tokens (#1646)
6a9d578
@paulAcato paulAcato requested a review from marcoderover January 9, 2025 08:25
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b58073d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
denhaag ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 8:34am

@paulAcato paulAcato self-assigned this Jan 9, 2025
@paulAcato paulAcato merged commit 369c657 into www.denhaag.nl Jan 9, 2025
6 checks passed
@paulAcato paulAcato deleted the www-denhaag-nl/reduce-unused-css branch January 9, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoderover marcoderover marcoderover approved these changes

Assignees

@paulAcato paulAcato

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulAcato @marcoderover