Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests whenever TMPDIR points to some folder with spaces in the name #3605

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link
Member

See #3604 for the motivation

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.04%. Comparing base (bae6c55) to head (52cc9c4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3605   +/-   ##
=======================================
  Coverage   73.04%   73.04%           
=======================================
  Files        1278     1278           
  Lines       59356    59356           
=======================================
  Hits        43359    43359           
  Misses      15997    15997           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member Author

oh well, I guess since no actual dcm2niix is invoked -- all is good here besides a single test test_crashfile_creation leading to /opt/hostedtoolcache/Python/3.11.5/x64/bin/python: can't open file '/tmp/t': [Errno 2] No such file or directory

@effigies effigies force-pushed the enh-test-tmpdir branch from 0573b86 to 2eabcc4 Compare May 6, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants