-
Notifications
You must be signed in to change notification settings - Fork 481
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #10467 from neondatabase/compute-rc-2025-01-21
Compute release 2025-01-21
- Loading branch information
Showing
74 changed files
with
3,461 additions
and
873 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| name: Check Codestyle Rust | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| build-tools-image: | ||
| description: "build-tools image" | ||
| required: true | ||
| type: string | ||
| archs: | ||
| description: "Json array of architectures to run on" | ||
| type: string | ||
|
|
||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash -euxo pipefail {0} | ||
|
|
||
| jobs: | ||
| check-codestyle-rust: | ||
| strategy: | ||
| matrix: | ||
| arch: ${{ fromJson(inputs.archs) }} | ||
| runs-on: ${{ fromJson(format('["self-hosted", "{0}"]', matrix.arch == 'arm64' && 'small-arm64' || 'small')) }} | ||
|
|
||
| container: | ||
| image: ${{ inputs.build-tools-image }} | ||
| credentials: | ||
| username: ${{ secrets.NEON_DOCKERHUB_USERNAME }} | ||
| password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }} | ||
| options: --init | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: true | ||
|
|
||
| - name: Cache cargo deps | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| ~/.cargo/registry | ||
| !~/.cargo/registry/src | ||
| ~/.cargo/git | ||
| target | ||
| key: v1-${{ runner.os }}-${{ runner.arch }}-cargo-${{ hashFiles('./Cargo.lock') }}-${{ hashFiles('./rust-toolchain.toml') }}-rust | ||
|
|
||
| # Some of our rust modules use FFI and need those to be checked | ||
| - name: Get postgres headers | ||
| run: make postgres-headers -j$(nproc) | ||
|
|
||
| # cargo hack runs the given cargo subcommand (clippy in this case) for all feature combinations. | ||
| # This will catch compiler & clippy warnings in all feature combinations. | ||
| # TODO: use cargo hack for build and test as well, but, that's quite expensive. | ||
| # NB: keep clippy args in sync with ./run_clippy.sh | ||
| # | ||
| # The only difference between "clippy --debug" and "clippy --release" is that in --release mode, | ||
| # #[cfg(debug_assertions)] blocks are not built. It's not worth building everything for second | ||
| # time just for that, so skip "clippy --release". | ||
| - run: | | ||
| CLIPPY_COMMON_ARGS="$( source .neon_clippy_args; echo "$CLIPPY_COMMON_ARGS")" | ||
| if [ "$CLIPPY_COMMON_ARGS" = "" ]; then | ||
| echo "No clippy args found in .neon_clippy_args" | ||
| exit 1 | ||
| fi | ||
| echo "CLIPPY_COMMON_ARGS=${CLIPPY_COMMON_ARGS}" >> $GITHUB_ENV | ||
| - name: Run cargo clippy (debug) | ||
| run: cargo hack --features default --ignore-unknown-features --feature-powerset clippy $CLIPPY_COMMON_ARGS | ||
|
|
||
| - name: Check documentation generation | ||
| run: cargo doc --workspace --no-deps --document-private-items | ||
| env: | ||
| RUSTDOCFLAGS: "-Dwarnings -Arustdoc::private_intra_doc_links" | ||
|
|
||
| # Use `${{ !cancelled() }}` to run quck tests after the longer clippy run | ||
| - name: Check formatting | ||
| if: ${{ !cancelled() }} | ||
| run: cargo fmt --all -- --check | ||
|
|
||
| # https://github.com/facebookincubator/cargo-guppy/tree/bec4e0eb29dcd1faac70b1b5360267fc02bf830e/tools/cargo-hakari#2-keep-the-workspace-hack-up-to-date-in-ci | ||
| - name: Check rust dependencies | ||
| if: ${{ !cancelled() }} | ||
| run: | | ||
| cargo hakari generate --diff # workspace-hack Cargo.toml is up-to-date | ||
| cargo hakari manage-deps --dry-run # all workspace crates depend on workspace-hack | ||
| # https://github.com/EmbarkStudios/cargo-deny | ||
| - name: Check rust licenses/bans/advisories/sources | ||
| if: ${{ !cancelled() }} | ||
| run: cargo deny check --hide-inclusion-graph |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
c68b346There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6700 tests run: 6362 passed, 0 failed, 338 skipped (full report)
Flaky tests (5)
Postgres 17
test_scrubber_physical_gc_ancestors[2]: release-arm64, release-arm64test_timeline_archive[4]: release-x86-64Postgres 16
test_scrubber_physical_gc_ancestors[2]: release-arm64Postgres 15
test_pageserver_metrics_removed_after_detach: release-arm64Test coverage report is not available
c68b346 at 2025-01-22T07:41:33.814Z :recycle: