Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: add math.pow #836

Closed
wants to merge 16 commits into from
Closed

Add: add math.pow #836

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a8bf28c
add math.pow
Jim8y Dec 15, 2023
7e2a289
add UT
Jim8y Dec 15, 2023
4e59d26
Merge branch 'master' into math.pow
Jim8y Dec 17, 2023
a657696
Merge branch 'master' into math.pow
Jim8y Dec 18, 2023
38a3eea
add Math of our own
Jim8y Dec 19, 2023
4dbe5fc
Merge branch 'master' into math.pow
Jim8y Dec 19, 2023
9029232
add UT tests
Jim8y Dec 19, 2023
b9750bf
Merge branch 'math.pow' of github.com:Liaojinghui/neo-devpack-dotnet …
Jim8y Dec 19, 2023
c9ee7e2
Update src/Neo.SmartContract.Framework/Math.cs
shargon Dec 19, 2023
6a0d22b
Update src/Neo.SmartContract.Framework/Math.cs
shargon Dec 19, 2023
60bbfb7
Merge branch 'master' into math.pow
shargon Dec 19, 2023
6506918
remove system convert and ensure that new Math methods still generate…
Jim8y Dec 20, 2023
6aa388a
Merge branch 'master' into math.pow
Jim8y Dec 31, 2023
87bbaaf
recover System.Math
Jim8y Dec 31, 2023
6468ad0
Merge branch 'master' into math.pow
Jim8y Feb 10, 2024
7cfdafc
use neo math
Jim8y Feb 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Neo.Compiler.CSharp/MethodConvert.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4182,6 +4182,7 @@ private bool TryProcessSystemMethods(SemanticModel model, IMethodSymbol symbol,
AddInstruction(OpCode.SIGN);
return true;
case "System.Numerics.BigInteger.Pow(System.Numerics.BigInteger, int)":
case "System.Math.Pow(double, double)":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we haven't got double or float compatibility

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes and no. yes it uses double and neo does not support double. no it is c#, and it compiles and works well. truth is, we can not prevent developer from using double at all, it actually works in neo, c# convert them implecitly into int or other types, we cant prevent it, we cant detect it, we even 'support' it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will do some study on this, maybe ban those key words from source level.

if (arguments is not null)
PrepareArgumentsForMethod(model, symbol, arguments, CallingConvention.StdCall);
AddInstruction(OpCode.POW);
Expand Down
6 changes: 6 additions & 0 deletions tests/Neo.Compiler.CSharp.UnitTests/TestClasses/Contract_Math.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.Numerics;

namespace Neo.Compiler.CSharp.UnitTests.TestClasses
{
Expand All @@ -23,5 +24,10 @@ public static int abs(int a)
{
return Math.Abs(a);
}

public static double pow(int a, int b)
{
return Math.Pow(a, b);
}
}
}
22 changes: 22 additions & 0 deletions tests/Neo.Compiler.CSharp.UnitTests/UnitTest_Math.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,5 +91,27 @@ public void abs_test()
Assert.AreEqual(VMState.HALT, _engine.State);
Assert.AreEqual(0, result.Pop().GetInteger());
}

[TestMethod]
public void pow_test()
{
_engine.Reset();
var result = _engine.ExecuteTestCaseStandard("pow", 10, 10);

Assert.AreEqual(VMState.HALT, _engine.State);
Assert.AreEqual(10000000000, result.Pop().GetInteger());

_engine.Reset();
result = _engine.ExecuteTestCaseStandard("pow", 10, 0);

Assert.AreEqual(VMState.HALT, _engine.State);
Assert.AreEqual(1, result.Pop().GetInteger());

_engine.Reset();
result = _engine.ExecuteTestCaseStandard("pow", 100, 1);

Assert.AreEqual(VMState.HALT, _engine.State);
Assert.AreEqual(100, result.Pop().GetInteger());
}
}
}