Cumsum cumprod #492
Merged
Cumsum cumprod #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you add a test in the test suite? Ultimately we likely want that parallelized and a test would be helpful to ensure that we don't mess it up. |
|
I added the test for these procedures. I'm gonna commit the changes. |
mratsim
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Nim's early symbol resolution strikes again :/ nim-lang/Nim#8677 nim-lang/Nim#6387
| ## - t: a rank-n tensor to cumulatively sum | ||
| ## - axis: int | ||
| ## Returns: | ||
| ## - A tensor cumulatively summed at axis, that is, add each value to |
There was a problem hiding this comment.
can you add mixin _ here, it seems like the _ symbol is not visible in some cases and breaks CI
| ## - t: a rank-n tensor to cumulatively sum | ||
| ## - axis: int | ||
| ## Returns: | ||
| ## - A tensor cumulatively summed at axis, that is, add each value to |
There was a problem hiding this comment.
and similar here can you add mixin _ here, it seems like the _ symbol is not visible in some cases and breaks CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the issue: #491 @HugoGranstrom helped me develop those two procedures:
cumsumandcumprod, which are very useful to scientific computing and finance.