Skip to content

Commit

Permalink
Merge pull request #661 from mit-ll-responsible-ai/avoid-importlib-issue
Browse files Browse the repository at this point in the history
CI-only: Pin importlib-resources<6.2
  • Loading branch information
rsokl authored Mar 17, 2024
2 parents a201123 + d5aa2c2 commit fa57d0e
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 2 deletions.
18 changes: 16 additions & 2 deletions .github/workflows/tox_run.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

strategy:
matrix:
python-version: [3.8, 3.9, "3.10", 3.11, 3.12]
python-version: [3.9, "3.10", 3.11, 3.12]
fail-fast: false

steps:
Expand Down Expand Up @@ -122,7 +122,21 @@ jobs:
- name: Test with tox
run: tox -e min-deps


python-38:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Python 3.8
uses: actions/setup-python@v5
with:
python-version: 3.8
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install tox tox-gh-actions
- name: Test with tox
run: tox -e v38

test-against-pre-releases-of-dependencies:
runs-on: ubuntu-latest
steps:
Expand Down
6 changes: 6 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -154,13 +154,19 @@ deps = setuptools
tzdata
commands = pytest tests/ {posargs: -n auto --maxprocesses=4}
[testenv:v38]
deps = {[testenv]deps}
importlib-resources<6.2.0
basepython = python3.8
[testenv:min-deps]
description = Runs test suite against minimum supported versions of dependencies.
deps = hydra-core==1.2.0
omegaconf==2.2.1
typing-extensions==4.1.0
{[testenv]deps}
importlib-resources<6.2.0
basepython = python3.8
Expand Down

0 comments on commit fa57d0e

Please sign in to comment.