Merge pull request #554 from mit-ll-responsible-ai/fix-ci

CI compatibility with cloudpickle 3.0.0
mit-ll-responsible-ai · Oct 19, 2023 · 2674fd5 · 2674fd5
2 parents d56abd1 + 2d298bb
commit 2674fd5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/hydra_zen/_launch.py b/src/hydra_zen/_launch.py
@@ -484,7 +484,7 @@ def launch(
             job = sweeper.sweep(arguments=task_overrides)
             callbacks.on_multirun_end(config=cfg, config_name=config_name)
 
-    if is_dataclass(config):
+    if is_dataclass(config):  # pragma: no cover
         _num_dataclass_fields_after = len(fields(config))
         if (
             _num_dataclass_fields_after == 0

diff --git a/tests/test_launch/test_implementations.py b/tests/test_launch/test_implementations.py
@@ -1,6 +1,7 @@
 # Copyright (c) 2023 Massachusetts Institute of Technology
 # SPDX-License-Identifier: MIT
 
+import dataclasses
 from pathlib import Path
 from typing import Optional
 
@@ -15,8 +16,6 @@
 from hydra_zen._launch import _store_config
 
 try:
-    import dataclasses
-
     import cloudpickle
 
     CLOUDPICKLE_AVAIL = True
@@ -74,7 +73,7 @@ def task_fn(cfg):
     launch(cfg, task_function=task_fn, to_dictconfig=to_dictconfig, **version_base)
 
     if pre_num_fields > 0:
-        if not to_dictconfig:
+        if not to_dictconfig and int(cloudpickle.__version__.split(".")[0]) < 3:
             assert len(dataclasses.fields(cfg)) == 0
         else:
             assert len(dataclasses.fields(cfg)) > 0