Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Key Concepts" documentation #5275

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Jan 9, 2025

Summary

This adds a new page that gives an overview of the different concepts in
Minder. It starts adding the items that were recently implemented and
are yet to be documented

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX requested a review from a team as a code owner January 9, 2025 15:04
## Data Sources

Data sources complement providers by fetching additional contextual information from
third-party APIs. While providers manage entities, data sources provide:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about updating the examples below, so it doesn't sound like data sources are solely for the purpose of enriching information about dependencies?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes, what do you think?


2. *Evaluation*: Minder evaluates the entity against defined policies.

3. *Remediation*: Issues identified during evaluation are flagged or resolved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be called Actions or perhaps add Alerting too to the list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, wdyt?

@JAORMX JAORMX force-pushed the key-concepts branch 2 times, most recently from 35fe1f7 to e5b5f99 Compare January 10, 2025 08:03
@coveralls
Copy link

coveralls commented Jan 10, 2025

Coverage Status

coverage: 56.592%. remained the same
when pulling 6c66366 on JAORMX:key-concepts
into c90e428 on mindersec:main.

This adds a new page that gives an overview of the different concepts in
Minder. It starts adding the items that were recently implemented and
are yet to be documented

Signed-off-by: Juan Antonio Osorio <[email protected]>
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this doc! Having some content and a straw-man organization really helped me wrap my head around what information we might want to present.

Let me know if you want me to PR to your branch for any of this content; I recognize that I've suggested a fairly large content rework.

Providers communicate with Minder through APIs, webhook events, and scheduled updates. This ensures
continuous monitoring and up-to-date information about the entities they manage.

## Entities and Checkpoints
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like if I were introducing Minder, I'd start with Entities, then move on to Providers ("where do entities come from"), then move on to "what do I do with entities" to introduce Profiles and Rules (I don't think we have a "Policy" entity), probably starting with the collection (Profiles) and then going down to RuleTypes.

I'd think of all of the above as "control plane" concepts -- they cover long-lived resources that users might create or manage directly.

I'd then have a second section on "Rule Evaluation" -- the "data plane" of Minder where things change based on external activity. I'd probably lay this out as "what is an Evaluation" (introduce the stages of ingestion, evaluation, remediation, and alerting), then talk about Ingesters, Checkpoints, Evaluation Engines (Rego and JQ), Data Sources, and Remediations and Alerts.

Here's a TOC, I think we could mostly just re-arrange the content:

  • General Minder Introduction
  • Managing Supply Chains with Minder
    • Entities
    • Providers
      • Origination
    • Profiles
      • Rule Types
  • Executing Policy with Minder
    • The Phases of Rule Evaluation
    • Ingesters
      • Checkpoints
      • Historical Evaluation records
    • Evaluation Engines
      • Data Sources
    • Remediations and Alerts

Comment on lines +29 to +33
Checkpoints are points in time that capture the state of an entity. These snapshots enable:

* Auditability: Tracking changes and compliance over time.

* Granular Analysis: Evaluating an entity’s state at specific moments, such as a commit hash or artifact digest.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can users see checkpoints, or are those an internal implementation detail? I wasn't aware that we were exposing these externally.


* Granular Analysis: Evaluating an entity’s state at specific moments, such as a commit hash or artifact digest.

**Entity Lifecycle**:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: why not use semantic markup (###) rather than bold styling?


3. *Action*: Issues identified during evaluation are either remediated or alerted.

## Policies, Rules, and Profiles
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Policies, Rules, and Profiles
## Rules and Profiles

Comment on lines +54 to +70
## Origination

Origination describes one type of relationships between entities. For instance:

* A pull request originates from a repository.

This concept ensures that Minder maintains lifecycle consistency by:

* Automatically creating derived entities (e.g., pull requests) based on originating ones.

* Cleaning up dependent entities when the originating entity is removed.

Example Relationships:

Repository -> Pull Request

Repository -> Release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels weird here -- it feels like it belongs with either providers or entity lifecycle ("where do entities come from")

@JAORMX
Copy link
Contributor Author

JAORMX commented Jan 10, 2025

PRing to this PR is fine! Thanks for the thorough review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants