Skip to content

Commit

Permalink
Add mindev ruletype init to kick off a rule type
Browse files Browse the repository at this point in the history
This helps folks set up the basic skeleton for ruletype writing.

Signed-off-by: Juan Antonio Osorio <[email protected]>
  • Loading branch information
JAORMX committed Dec 19, 2024
1 parent 0068f4d commit 213adf2
Show file tree
Hide file tree
Showing 2 changed files with 188 additions and 0 deletions.
187 changes: 187 additions & 0 deletions cmd/dev/app/rule_type/init.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,187 @@
// SPDX-FileCopyrightText: Copyright 2023 The Minder Authors
// SPDX-License-Identifier: Apache-2.0

package rule_type

import (
"errors"
"fmt"
"github.com/spf13/cobra"
"os"
"path/filepath"
"regexp"
)

// CmdInit is the command for initializing a rule type definition
func CmdInit() *cobra.Command {
initCmd := &cobra.Command{
Use: "init",
Short: "initialize a rule type definition",
Long: `The 'ruletype init' subcommand allows you to initialize a rule type definition
The first positional argument is the directory to initialize the rule type in.
The rule type will be initialized in the current directory if no directory is provided.
`,
RunE: initCmdRun,
SilenceUsage: true,
}

initCmd.Flags().StringP("name", "n", "", "name of the rule type")
initCmd.Flags().BoolP("skip-tests", "s", false, "skip creating test files")

if err := initCmd.MarkFlagRequired("name"); err != nil {
fmt.Fprintf(os.Stderr, "Error marking flag as required: %s\n", err)
os.Exit(1)
}

return initCmd
}

func initCmdRun(cmd *cobra.Command, args []string) error {
name := cmd.Flag("name").Value.String()
skipTests := cmd.Flag("skip-tests").Value.String() == "true"
dir := "."
if len(args) > 0 {
dir = args[0]
}

if err := validateRuleTypeName(name); err != nil {
return err
}

ruleTypeFileName := filepath.Join(dir, name+".yaml")
ruleTypeTestFileName := filepath.Join(dir, name+".test.yaml")
ruleTypeTestDataDirName := filepath.Join(dir, name+".testdata")

if err := assertFilesDontExist(
ruleTypeFileName, ruleTypeTestFileName, ruleTypeTestDataDirName); err != nil {
return err
}

// Create rule type file
if err := createRuleTypeFile(ruleTypeFileName, name); err != nil {
return err
}
cmd.Printf("Created rule type file: %s\n", ruleTypeFileName)

if !skipTests {
// Create rule type test file
if err := createRuleTypeTestFile(ruleTypeTestFileName, name); err != nil {
return err
}
cmd.Printf("Created rule type test file: %s\n", ruleTypeTestFileName)

// Create rule type test data directory
if err := createRuleTypeTestDataDir(ruleTypeTestDataDirName); err != nil {
return err
}
cmd.Printf("Created rule type test data directory: %s\n", ruleTypeTestDataDirName)
}

return nil
}

func validateRuleTypeName(name string) error {
if name == "" {
return errors.New("name cannot be empty")
}

validName := regexp.MustCompile(`^[a-zA-Z0-9_]+$`)

// regexp to validate name
if !validName.MatchString(name) {
return errors.New("name must only contain alphanumeric characters and underscores")
}

return nil
}

func assertFilesDontExist(files ...string) error {
for _, file := range files {
if _, err := os.Stat(file); err == nil {

return fmt.Errorf("file %s already exists", file)
}
}

return nil
}

func createRuleTypeFile(fileName, name string) error {
return createFileWithContent(fileName, fmt.Sprintf(`---
version: v1
release_phase: alpha
type: rule-type
name: %s
display_name: # Display name for the rule type
short_failure_message: # Short message to display when the rule fails
severity:
value: medium
context: {}
description: | # Description of the rule type
guidance: | # Guidance for the rule type. This helps users understand how to fix the issue.
def:
in_entity: repository # The entity type the rule applies to
rule_schema: {}
ingest:
type: git
git:
eval:
type: rego
rego:
type: deny-by-default
def: |
package minder
import rego.v1
default allow := false
allow if {
true
}
message := "This is a test message"
`, name))
}

func createRuleTypeTestFile(fileName, name string) error {

Check failure on line 148 in cmd/dev/app/rule_type/init.go

View workflow job for this annotation

GitHub Actions / lint / Run golangci-lint

unused-parameter: parameter 'name' seems to be unused, consider removing or renaming it as _ (revive)
return createFileWithContent(fileName, `---
tests:
- name: "TEST NAME GOES HERE""
def: {}
params: {}
expect: "pass"
entity: &test-repo
type: repository
entity:
owner: "coolhead"
name: "haze-wave"
# http:
# body_file: HTTP_BODY_FILE
# git:
# repo_base: REPO_BASE_PATH
`)
}

func createRuleTypeTestDataDir(dirName string) error {
if err := os.Mkdir(dirName, 0755); err != nil {

Check failure on line 168 in cmd/dev/app/rule_type/init.go

View workflow job for this annotation

GitHub Actions / lint / Run golangci-lint

G301: Expect directory permissions to be 0750 or less (gosec)
return fmt.Errorf("error creating directory %s: %w", dirName, err)
}

return nil
}

func createFileWithContent(fileName, content string) error {
file, err := os.Create(fileName)

Check failure on line 176 in cmd/dev/app/rule_type/init.go

View workflow job for this annotation

GitHub Actions / lint / Run golangci-lint

G304: Potential file inclusion via variable (gosec)
if err != nil {
return fmt.Errorf("error creating file %s: %w", fileName, err)
}
defer file.Close()

if _, err := file.WriteString(content); err != nil {
return fmt.Errorf("error writing to file %s: %w", fileName, err)
}

return nil
}
1 change: 1 addition & 0 deletions cmd/dev/app/rule_type/ruletype.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ func CmdRuleType() *cobra.Command {
rtCmd.AddCommand(CmdTest())
rtCmd.AddCommand(CmdLint())
rtCmd.AddCommand(CmdValidateUpdate())
rtCmd.AddCommand(CmdInit())

return rtCmd
}

0 comments on commit 213adf2

Please sign in to comment.