Fix DynamicData.GetData regression preventing it to work without adapter #4620
+193
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Jan 12, 2025
| @@ -235,6 +234,7 @@ private static bool IsTupleOrValueTuple(Type type, out int tupleSize) | |||
| return true; | |||
| } | |||
|
|
|||
| #if !NET462 // TODO: Add dependency on System.ValueTuple for net462? | |||
There was a problem hiding this comment.
@Evangelink Thoughts?
Youssef1313
force-pushed
the
dynamicdata-reg
branch
3 times, most recently
from
e1d4338 to
68adc5b
Compare
Youssef1313
force-pushed
the
dynamicdata-reg
branch
from
68adc5b to
f6a8f02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4619