Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TestMethodRunner.Execute so that it returns TestResult (from TestFramework) rather than UnitTestResult (from TestAdapter) #4591

Merged
merged 5 commits into from
Jan 13, 2025
Merged

Refactor TestMethodRunner.Execute so that it returns TestResult (from TestFramework) rather than UnitTestResult (from TestAdapter) #4591

merged 5 commits into from
Jan 13, 2025

Conversation

Youssef1313
Copy link
Member

No description provided.

@Youssef1313
Refactor TestMethodRunner.Execute so that it returns TestResult (from…
65ddc02 
… TestFramework) rather than UnitTestResult (from TestAdapter)
Evangelink
Evangelink previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT but do we need the change to List?

@Youssef1313 Youssef1313 force-pushed the refactor-testmethodrunner branch from f226cd5 to e2e50a7 Compare January 10, 2025 14:54
@Youssef1313
Copy link
Member Author

LGMT but do we need the change to List?

Avoiding List<TestResult> -> TestResult[] -> UnitTestResult[] and instead going List<TestResult> -> UnitTestResult[] directly. We shouldn't be needing UnitTestResult at all and I'll investigate that separately.

@Youssef1313 Youssef1313 mentioned this pull request Jan 10, 2025
Closed
@Evangelink Evangelink merged commit c749676 into microsoft:main Jan 13, 2025
10 checks passed
@Youssef1313 Youssef1313 deleted the refactor-testmethodrunner branch January 13, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Youssef1313 @Evangelink