Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove destructor pattern from LogMessageListener #4585

25 changes: 3 additions & 22 deletions src/Adapter/MSTest.TestAdapter/Execution/LogMessageListener.cs
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,6 @@ public LogMessageListener(bool captureDebugTraces)
}
}

~LogMessageListener()
{
Dispose(false);
}

/// <summary>
/// Gets logger output.
/// </summary>
Expand All @@ -108,31 +103,17 @@ public LogMessageListener(bool captureDebugTraces)
[SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "Part of the public API")]
public string? DebugTrace => s_redirectedDebugTrace?.ToString();

public string? GetAndClearStandardOutput()
{
string? output = _redirectedStandardOutput.ToStringAndClear();
return output;
}
public string? GetAndClearStandardOutput() => _redirectedStandardOutput.ToStringAndClear();

public string? GetAndClearStandardError()
{
string? output = _redirectedStandardError.ToStringAndClear();
return output;
}
public string? GetAndClearStandardError() => _redirectedStandardError.ToStringAndClear();

[SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "Part of the public API")]
public string? GetAndClearDebugTrace()
=> s_redirectedDebugTrace?.ToStringAndClear();

public void Dispose()
{
Dispose(true);
GC.SuppressFinalize(this);
}

private void Dispose(bool disposing)
{
if (!disposing || _isDisposed)
if (_isDisposed)
{
return;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
#nullable enable
*REMOVED*Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.LogMessageListener.~LogMessageListener() -> void
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
#nullable enable
*REMOVED*Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.LogMessageListener.~LogMessageListener() -> void
Loading