Pre-requisites of upgrading EMSDK #23347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 10 changed files in this pull request and generated 1 comment.
Files not reviewed (6)
- cmake/CMakeLists.txt: Language not supported
- cmake/onnxruntime_config.h.in: Language not supported
- cmake/onnxruntime_unittests.cmake: Language not supported
- cmake/onnxruntime_webassembly.cmake: Language not supported
- js/package-lock.json: Language not supported
- js/package.json: Language not supported
Comments suppressed due to low confidence (1)
js/web/script/build.ts:148
- Ensure that the new Terser configuration is covered by tests to verify that it doesn't introduce any unintended behavior.
// Use terser to minify the code with special configurations:
js/web/test/e2e/exports/testcases/vite-default/src/components/onnx-helper.js
Outdated
Show resolved
Hide resolved
…onnx-helper.js Co-authored-by: Copilot <[email protected]>
guschmue
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a part of the changes in #23318.
The reason of creating this PR is: The works to support building WebGPU EP in WASM depends on #23318, which cannot be merged since it's blocked by upstream (llvm/llvm-project#122166). This PR contains the changes can be safely merged separately and can unblock the development of supporting building WebGPU EP in WASM.