Create Crypto binaries reporting tool #118
Conversation
…ike size and compile flags
github-actions
bot
added
the
language:python
| if binary not in source_sizes[arch]: | ||
| log_warning(f"A binary has been removed! - {binary} is not found in source report for architecture {arch}") # log warning - Missing Binary! | ||
|
|
||
| def comapre_linked_openssllib(source_linked_openssllib, target_linked_openssllib): |
There was a problem hiding this comment.
| def comapre_linked_openssllib(source_linked_openssllib, target_linked_openssllib): | |
| def compare_linked_openssllib(source_linked_openssllib, target_linked_openssllib): | |
| TOOL_CHAIN_TAG=${{ parameters.toolchain }} | ||
|
|
||
| # Compare crypto report |
There was a problem hiding this comment.
This is an okay place to put the report generating code. One thing to consider is how we're going to update the report we're using as a baseline. I think it would make sense as a pipeline or pipeline step to use the completed PRs report as the new baseline. Just something to think about.
There was a problem hiding this comment.
My thought was to produce a report in each release build as part of the pipeline artifacts.
Then in the PR, if the target branch is "Release/*" to pull the latest report generated for that release branch and that will be the baseline. I will appreciate other opinions and suggestions.
Further research is needed on how to public and grab such the report artifact properly
There was a problem hiding this comment.
That would work. The plan is to move to a main branch in the future but pulling the latest generated report for main would be fine.
| @@ -0,0 +1,63 @@ | |||
| #### RANDOM REPORT - NO REAL DATA! #### | |||
There was a problem hiding this comment.
I would like the actual openssl submodule commit to be linked in the report as well. Any changes there needs to be monitored.
There was a problem hiding this comment.
Good idea. I'll add submodules info as well.
Creating a reporting script to run in post build. This script will generate a report about the crypto binaries containing useful info like built binaries and their sizes, linked opensslLib*.inf and OpensslLib*.inf compilation flags.
The report will be placed in the build folder with the name "Report_"
The goal is to catch risky changes that can break functionality or influence the memory consumption (e.g. increase or decrease in flash size).
Moreover, this PR adds a comparison script to compare between 2 reports (the source and target branches of the PR) and warn against such risky changes.
This PR is marked for draft to test the report generation and comparison against a test report.
The goal is to generate a report in each release build and in each PR compare the source and target (release branch) branches reports.