MpDxe: Produce MpServices protocol as a standalone Mp dxe driver #1253
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #1253 +/- ##
==============================================
+ Coverage 1.56% 1.60% +0.03%
==============================================
Files 1377 1379 +2
Lines 358699 359635 +936
Branches 5524 5524
==============================================
+ Hits 5620 5760 +140
- Misses 352875 353768 +893
+ Partials 204 107 -97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vineelko
force-pushed
the
users/vineelko/mpdxe_0110_2
branch
from
0fcf892 to
c73c7a2
Compare
Signed-off-by: Vineel Kovvuri[MSFT] <[email protected]>
Signed-off-by: Vineel Kovvuri[MSFT] <[email protected]>
vineelko
force-pushed
the
users/vineelko/mpdxe_0110_2
branch
from
c73c7a2 to
158f195
Compare
| /** @file | ||
| MP DXE Module to produce MP Protocol. | ||
|
|
||
| Copyright (c) 2024, Loongson Technology Corporation Limited. All rights reserved.<BR> |
There was a problem hiding this comment.
Is Loongson the sole copyright owner for this file?
There was a problem hiding this comment.
That's okay given it is in the LoongArch64 directory, the code just looks familiar/common.
| VOID | ||
| ) | ||
| { | ||
| // // |
There was a problem hiding this comment.
The whole file is marked as a Mu change, but other sections also mark individual Mu changes. These commented lines should be marked too if each section is being marked.
UefiCpuPkg/MpDxe/MpDxe.h
Outdated
| #ifndef _MP_DXE_H_ | ||
| #define _MP_DXE_H_ |
There was a problem hiding this comment.
| #ifndef _MP_DXE_H_ | |
| #define _MP_DXE_H_ | |
| #ifndef MP_DXE_H_ | |
| #define MP_DXE_H_ |
| LoongArch64/MpDxe.c | ||
| MpDxe.h | ||
|
|
||
| [Protocols] |
There was a problem hiding this comment.
The double commented lines for gEfiCpuArchProtocolGuid are confusing with no further context.
# gEfiCpuArchProtocolGuid ## CONSUMES
# gEfiCpuArchProtocolGuid ## PRODUCES
There was a problem hiding this comment.
My bad Michael, I missed it, Will prune it.
UefiCpuPkg/MpDxe/MpDxe.inf
Outdated
|
|
||
| [Protocols] | ||
| gEfiMpServiceProtocolGuid ## PRODUCES | ||
| # gEfiCpuArchProtocolGuid ## CONSUMES |
There was a problem hiding this comment.
If this is a new driver, is there a point in commenting out irrelevant code? It could just be diffed against CpuDxe.inf if someone is interested in that, right?
|
Did you intentionally choose not to backport this to the release branch? "[ ] Backport to release branch?" |
github-actions
bot
added
the
type:backport
Signed-off-by: Vineel Kovvuri[MSFT] <[email protected]>
Description
This PR creates a fork of MP services functionality into a standalone Dxe driver. It is necessary to bring up platforms which do not rely on UEFI C based CpuDxe code. Existing Cpu Dxe and its MP services code remains the same.
How This Was Tested
Q35 Qemu boots.
Integration Instructions
No changes needed.