Removes SqlManagementObject references #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankowitz
force-pushed
the
personal/bkowitz/remove-sqlmanagementobjects
branch
from
801f900 to
be97f91
Compare
There was a problem hiding this comment.
Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (3)
- Directory.Packages.props: Language not supported
- src/Microsoft.Health.SqlServer/Microsoft.Health.SqlServer.csproj: Language not supported
- test/Microsoft.Health.SqlServer.Tests.Integration/Microsoft.Health.SqlServer.Tests.Integration.csproj: Language not supported
Comments suppressed due to low confidence (1)
src/Microsoft.Health.SqlServer/Features/Schema/Manager/SchemaManagerDataStore.cs:127
- The split by '\nGO' might not handle cases where 'GO' is part of a string or comment. Consider using a more robust method to split SQL scripts.
foreach (string statement in script.Split(["\nGO"], StringSplitOptions.RemoveEmptyEntries))
rbans96
reviewed
Jan 22, 2025
src/Microsoft.Health.SqlServer/Features/Schema/Manager/SchemaManagerDataStore.cs
Show resolved
Hide resolved
rbans96
approved these changes
Jan 22, 2025
wsugarman
approved these changes
Jan 23, 2025
brendankowitz
deleted the
personal/bkowitz/remove-sqlmanagementobjects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes Microsoft.SqlServer.SqlManagementObjects from ScriptRunner.
Microsoft.SqlServer.SqlManagementObjects does not support ActiveDirectortyWorkloadIdentity:
vs Microsoft.Data.SqlClient
Testing
Existing tests should pass.
Semver Change
Patch (Same functionality)