Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rysweet 5201 refactor runtime interface #5204

Merged
merged 7 commits into from
Jan 26, 2025

Conversation

rysweet
Copy link
Collaborator

@rysweet rysweet commented Jan 26, 2025

Changes to align the .NET code more with the python codebase.

  • rename *Worker to *Runtime
  • refactor shared runtime elements to AgentRuntimeBase
  • align runtime interface with python

Why are these changes needed?

Aligning the .NET with the python code and then we can evolve together from there.

Related issue number

Closes #5201

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 18 changed files in this pull request and generated no comments.

Files not reviewed (13)
  • dotnet/src/Microsoft.AutoGen/Core/AgentWorker.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/Core/IAgentWorker.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/Agents/IOAgent/WebAPIAgent/WebAPIAgent.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/Core.Grpc/App.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/Core/IAgentRuntimeExtensions.cs: Evaluated as low risk
  • dotnet/samples/dev-team/DevTeam.Backend/Program.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/Core/HostBuilderExtensions.cs: Evaluated as low risk
  • dotnet/test/Microsoft.AutoGen.Core.Tests/AgentTests.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/Core/AgentExtensions.cs: Evaluated as low risk
  • dotnet/test/Microsoft.AutoGen.Core.Grpc.Tests/AgentGrpcTests.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/Core.Grpc/GrpcAgentWorkerHostBuilderExtension.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/Core/App.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/Core.Grpc/GrpcAgentRuntime.cs: Evaluated as low risk
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.08%. Comparing base (138913b) to head (c2646c4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5204   +/-   ##
=======================================
  Coverage   70.08%   70.08%           
=======================================
  Files         179      179           
  Lines       11619    11619           
=======================================
  Hits         8143     8143           
  Misses       3476     3476           
Flag Coverage Δ
unittests 70.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rysweet rysweet merged commit 10e40b5 into main Jan 26, 2025
66 checks passed
@rysweet rysweet deleted the rysweet-5201-refactor-runtime-interface branch January 26, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET small refactor: bring core runtime abstractions more in line with python: runtime interface
2 participants