Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix user input in m1 #4995

Merged
merged 12 commits into from
Jan 13, 2025
Merged

fix: fix user input in m1 #4995

merged 12 commits into from
Jan 13, 2025

Conversation

jackgerrits
Copy link
Member

Closes #4975

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 59.09091% with 36 lines in your changes missing coverage. Please review.

Project coverage is 68.48%. Comparing base (0554fa3) to head (6a1295d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...gen-agentchat/src/autogen_agentchat/ui/_console.py 37.83% 23 Missing ⚠️
.../autogen-ext/src/autogen_ext/teams/magentic_one.py 0.00% 7 Missing ⚠️
.../src/autogen_agentchat/agents/_user_proxy_agent.py 82.85% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4995      +/-   ##
==========================================
- Coverage   68.57%   68.48%   -0.09%     
==========================================
  Files         156      156              
  Lines       10053    10126      +73     
==========================================
+ Hits         6894     6935      +41     
- Misses       3159     3191      +32     
Flag Coverage Δ
unittests 68.48% <59.09%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagb
Copy link
Collaborator

gagb commented Jan 10, 2025

image

Does not look like the right behavior. Console printed "enter your response: " and paused before printing anything else.

Works fine after I enter something,

@afourney
Copy link
Member

image Does not look like the right behavior. Console printed "enter your response: " and paused before printing anything else.

Works fine after I enter something,

Yes, the prompt is appearing before the messages are flushed. A fix is in progress

@jackgerrits jackgerrits changed the title fix: Add lock for input and output sychronization in m1 fix: fix user input in m1 Jan 11, 2025
@afourney afourney self-requested a review January 11, 2025 00:30
Copy link
Member

@afourney afourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working for me.

@jackgerrits jackgerrits added this to the 0.4.1 milestone Jan 13, 2025
@jackgerrits jackgerrits enabled auto-merge (squash) January 13, 2025 15:23
@jackgerrits jackgerrits merged commit 466848a into main Jan 13, 2025
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeError: Failed to get user input: Failed to get user input:
5 participants