[DO NOT MERGE]: EVM emulator #1142
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladbochok
reviewed
Dec 13, 2024
| // solhint-disable-next-line reason-string, gas-custom-errors | ||
| require(NONCE_HOLDER_SYSTEM_CONTRACT.getRawNonce(_newAddress) == 0x0); | ||
| // solhint-disable-next-line reason-string, gas-custom-errors | ||
| require(ACCOUNT_CODE_STORAGE_SYSTEM_CONTRACT.getCodeHash(uint256(uint160(_newAddress))) == 0x0); |
There was a problem hiding this comment.
Is it intended to be getCodeHash not getRawCodeHash?
There was a problem hiding this comment.
getRawCodeHash would be better here indeed
Comment on lines
1136
to
1139
| mstore(mul(10, 32), mload(sub(offset, 0x80)) | ||
| mstore(mul(11, 32), mload(sub(offset, 0x60)) | ||
| mstore(mul(12, 32), mload(sub(offset, 0x40)) | ||
| mstore(mul(13, 32), mload(sub(offset, 0x20)) |
There was a problem hiding this comment.
Suggested change
| mstore(mul(10, 32), mload(sub(offset, 0x80)) | |
| mstore(mul(11, 32), mload(sub(offset, 0x60)) | |
| mstore(mul(12, 32), mload(sub(offset, 0x40)) | |
| mstore(mul(13, 32), mload(sub(offset, 0x20)) | |
| mstore(mul(10, 32), mload(sub(offset, 0x80))) | |
| mstore(mul(11, 32), mload(sub(offset, 0x60))) | |
| mstore(mul(12, 32), mload(sub(offset, 0x40))) | |
| mstore(mul(13, 32), mload(sub(offset, 0x20))) |
There was a problem hiding this comment.
Interesting, compiler allows this
vladbochok
reviewed
Dec 13, 2024
|
|
||
| // Setting the version of the hash | ||
| hashedEVMBytecode = (hashedEVMBytecode | bytes32(uint256(EVM_BYTECODE_FLAG) << 248)); | ||
| hashedEVMBytecode = hashedEVMBytecode | bytes32(_bytecode.length << 224); |
There was a problem hiding this comment.
Should it be ?
Suggested change
| hashedEVMBytecode = hashedEVMBytecode | bytes32(_bytecode.length << 224); | |
| hashedEVMBytecode = hashedEVMBytecode | bytes32(lengthInWords << 224); |
There was a problem hiding this comment.
Actually it should be length of unpadded EVM bytecode in bytes. This will make EXTCODESIZE implementation in Emulator a lot simpler. Right now this encoding in versioned bytecode hash (padded evm code length) actually doesn't make any sense
0xVolosnikov
force-pushed
the
evm-emulator/fixes
branch
from
5e4477e to
9c9233e
Compare
0xVolosnikov
force-pushed
the
evm-emulator/fixes
branch
from
bc802b1 to
e7aa3a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist