Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass unknown parameter to pre_load, post_load, and validates_schema methods #1632

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

jforand
Copy link
Contributor

@jforand jforand commented Jul 16, 2020

When extending a schema, the value of self.unknown is not necessarily correct in pre_load methods.

class MySchema(Schema):

    ...

    @pre_load
    def this_is_wrong(self, data, **kwargs):
        print(self.unknown)
        return data


...
MySchema().load(data, unknown=INCLUDE)

will print 'raise' rather than 'include'.

@sloria
Copy link
Member

sloria commented Jan 13, 2025

sorry it took so long to review this. i agree that unknown should be passed to the load processors, for consistency with many and partial. i've updated the PR to also pass unknown to validate_schema methods.

@sloria sloria changed the title Pass unknown parameter to pre_load Pass unknown parameter to pre_load, post_load, and validates_schema methods Jan 13, 2025
@sloria sloria merged commit 356e21b into marshmallow-code:dev Jan 13, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants