Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add success variant to button component #943

Closed
wants to merge 1 commit into from

Conversation

aptcreativedesign
Copy link

This PR adds the variant "success" to buttons.

<flux:button type="submit" variant="success">Success</flux:button>

image

I understand that the "primary" variant is what is usually a success/confirmation.
However there have been times when I felt that the visual cue of a green button would be helpful to the user

@joshhanley joshhanley changed the title add green "success" variant to button stub Add success variant to button component Jan 1, 2025
@gustavosobrinho01
Copy link

This PR is very important, I will definitely use it.

@calebporzio
Copy link
Contributor

Thanks for the PR! I'm pretty protective of the button variants and keeping them slim. This would create a precedent I'm not sure I'm willing to support for other components and also might have styling implications for other theming. Going to close for now. Sry, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants