Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hoarder #729

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added hoarder #729

wants to merge 1 commit into from

Conversation

jlssmt
Copy link
Contributor

@jlssmt jlssmt commented Jan 7, 2025

No description provided.

@drizuid
Copy link
Member

drizuid commented Jan 11, 2025

were both of these tested? do they work fully? does api work? literally no info here.

@drizuid drizuid added the invalid This doesn't seem right label Jan 11, 2025
@jlssmt
Copy link
Contributor Author

jlssmt commented Jan 11, 2025

Yep. I'm using it and api is also working.

@drizuid
Copy link
Member

drizuid commented Jan 11, 2025

Yep. I'm using it and api is also working.

in the future, please note when you have tested your PR and all functions of it. Can you please confirm you actually tested subfolder as well, since you state "im using it" rather than "im using them" and it'd be abnormal to use both subdomain and subfolder concurrently.

@jlssmt
Copy link
Contributor Author

jlssmt commented Jan 12, 2025

you're right. i'm only using and have tested the subdomain config which is working.
the subfolder config is not working for me but maybe the problem is my environment.
i can remove the subfolder config from this PR.

for future i will only submit the subdomain config and write in the description that it's tested by me.

@jlssmt jlssmt force-pushed the hoarder branch 3 times, most recently from 0bccd60 to 11e54ad Compare January 12, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
Status: PRs Approved
Development

Successfully merging this pull request may close these issues.

2 participants