*added version info and build time info #69
Conversation
*added vscode settings to exclude *max_payload_size to more clear size
|
couple points:
thanks! |
| @@ -1,7 +1,10 @@ | |||
| QDL := qdl | |||
| RAMDUMP := qdl-ramdump | |||
|
|
|||
| CFLAGS += -O2 -Wall -g `pkg-config --cflags libxml-2.0 libusb-1.0` | |||
| BUILD_TIME := $(shell date +"%c") | |||
There was a problem hiding this comment.
This makes the build unreproducible. Should use SOURCE_DATE_EPOCH, see https://reproducible-builds.org/docs/source-date-epoch/
There was a problem hiding this comment.
Why is this information valuable. Please use the commit message to describe your motivation.
There was a problem hiding this comment.
sure, next time, when I will debug non working qdl at the PC of my colleague may be I will return to this change ;-)
| @@ -1,7 +1,10 @@ | |||
| QDL := qdl | |||
| RAMDUMP := qdl-ramdump | |||
|
|
|||
| CFLAGS += -O2 -Wall -g `pkg-config --cflags libxml-2.0 libusb-1.0` | |||
| BUILD_TIME := $(shell date +"%c") | |||
| VERSION := "1.0.0" | |||
There was a problem hiding this comment.
Probably good to add git-version info (git describe) as well or instead.
There was a problem hiding this comment.
For the version information to be useful (e.g. for bug reports etc), we need to bump this version string on every commit. So, I think git describe provides much more value here.
| @@ -1,7 +1,10 @@ | |||
| QDL := qdl | |||
| RAMDUMP := qdl-ramdump | |||
|
|
|||
| CFLAGS += -O2 -Wall -g `pkg-config --cflags libxml-2.0 libusb-1.0` | |||
| BUILD_TIME := $(shell date +"%c") | |||
There was a problem hiding this comment.
Why is this information valuable. Please use the commit message to describe your motivation.
| @@ -1,7 +1,10 @@ | |||
| QDL := qdl | |||
| RAMDUMP := qdl-ramdump | |||
|
|
|||
| CFLAGS += -O2 -Wall -g `pkg-config --cflags libxml-2.0 libusb-1.0` | |||
| BUILD_TIME := $(shell date +"%c") | |||
| VERSION := "1.0.0" | |||
There was a problem hiding this comment.
For the version information to be useful (e.g. for bug reports etc), we need to bump this version string on every commit. So, I think git describe provides much more value here.
| @@ -192,7 +192,7 @@ static int firehose_write(struct qdl_device *qdl, xmlDoc *doc) | |||
| return ret < 0 ? -saved_errno : 0; | |||
| } | |||
|
|
|||
| static size_t max_payload_size = 1048576; | |||
| static size_t max_payload_size = 1024*1024; | |||
| @@ -111,6 +111,7 @@ int main(int argc, char **argv) | |||
| int opt; | |||
| bool qdl_finalize_provisioning = false; | |||
|
|
|||
| printf("QDL version %s %s\n", VERSION, BUILD_TIME); | |||
There was a problem hiding this comment.
I'd like to make the tool less noisy... How about instead adding a --version argument which prints the version and exits?
*added vscode settings to exclude
*max_payload_size to more clear size