-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the problem of Workflow terminates after parallel tasks execution, merge node not triggered #12498
base: main
Are you sure you want to change the base?
Conversation
I found that this issue still exists in some scenarios and has not been fully resolved. Please hold off on merging this pull request. |
The new code passes all graph engine unit tests and has been verified in several corner cases tested on the web app. Please review the code thoroughly and engage in a detailed discussion to ensure that the issue is truly resolved without breaking any existing functionality. |
amazing work! |
you need to fix the mypy typehint |
thx for the reminder. |
Done the file reformating and lint fixing. |
|
Summary
Fix #12492
Description
When both if conditions are satisfied, the subsequent node is executed incompletely due to the following reasons:
_run_parallel_branches creates a new thread for each branch to execute.
However:
Major Modifications:
This ensures that when multiple if condition branches are satisfied, their shared subsequent nodes are executed correctly.
Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods