Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logger.md #361

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Update logger.md #361

merged 2 commits into from
Jan 2, 2025

Conversation

ygxiaobai111
Copy link
Contributor

@ygxiaobai111 ygxiaobai111 commented Dec 30, 2024

Checklist

  • Dependencies installed
  • No typos
  • Searched existing issues and docs

@ygxiaobai111
Copy link
Contributor Author

I tried to run each example code in the logger one by one, and then put the output into the document. Meanwhile, I also summarized some of the errors that occurred during the debugging process.

@ygxiaobai111
Copy link
Contributor Author

ygxiaobai111 commented Dec 30, 2024

@aldas This RP corresponds to:echo-issue2665

Copy link
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes are required but overall I think this is OK.

website/docs/middleware/logger.md Outdated Show resolved Hide resolved
website/docs/middleware/logger.md Show resolved Hide resolved
website/docs/middleware/logger.md Outdated Show resolved Hide resolved
@ygxiaobai111
Copy link
Contributor Author

@aldas Okay, I'll try to make modifications to these parts and then create a Pull Request (PR) again.

@aldas
Copy link
Contributor

aldas commented Jan 2, 2025

no need for new PR. just add/push another commit on top of this PR and I will squash all of these commits into single one before it gets merged.

@ygxiaobai111
Copy link
Contributor Author

@aldas Got it. Thank you for your guidance.

@aldas aldas merged commit f8fc1c3 into labstack:master Jan 2, 2025
1 check passed
@aldas
Copy link
Contributor

aldas commented Jan 2, 2025

@ygxiaobai111, merged. Thanks for the PR. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants