Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIG Architecture: Enhancements spotlight #526

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Add SIG Architecture: Enhancements spotlight #526

merged 3 commits into from
Jan 17, 2025

Conversation

fsmunoz
Copy link
Contributor

@fsmunoz fsmunoz commented Sep 6, 2024

Add SIG Architecture: Enhancements subproject spotlight.

Closes: #501

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 6, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 6, 2024
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Sep 6, 2024

Holding for revision and opening of the website PR

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2024
@fsmunoz fsmunoz mentioned this pull request Sep 12, 2024
Merged
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Sep 12, 2024

Created the website PR: kubernetes/website#47902 . This should be OK to go (barring more suggestions, of course)

@fsmunoz
Copy link
Contributor Author

fsmunoz commented Oct 4, 2024

/cc @kikisdeliveryservice

@sftim
Copy link
Contributor

sftim commented Oct 19, 2024

This is ready for review.

@fsmunoz
Copy link
Contributor Author

fsmunoz commented Oct 25, 2024

I've updated the date for October 30th.

@kikisdeliveryservice
Copy link
Member

This looks great. Thank you @fsmunoz !

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2024
@fsmunoz fsmunoz force-pushed the sig-arch-enhancements-spotlight branch from 7d5e61d to dde11b9 Compare October 30, 2024 09:29
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2024
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Oct 30, 2024

Applied all the reviews in the website PR and rebased both. This should be good to go.

@sftim
Copy link
Contributor

sftim commented Nov 11, 2024

Reviews are welcome!

@fsmunoz
Copy link
Contributor Author

fsmunoz commented Nov 22, 2024

Updated publication date.

@fsmunoz fsmunoz mentioned this pull request Dec 6, 2024
Open
sftim
sftim reviewed Dec 22, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we try for January publication?

I can't promise that reviewers will show up; if they don't, I can do the review and approval myself [I'm keen to bring in other people so it's not just me each time].

lhajouji

This comment was marked as off-topic.

Sign in to view

@sftim
Copy link
Contributor

sftim commented Jan 2, 2025

@lhajouji - when we quote people's speech, and we then review that quote, we typically don't correct the wording or grammar of what is quoted. Punctuation is usually OK.

@lhajouji
Copy link

lhajouji commented Jan 2, 2025

@lhajouji - when we quote people's speech, and we then review that quote, we typically don't correct the wording or grammar of what is quoted. Punctuation is usually OK.

@sftim , Got it, thanks for the clarification. I've hidden my previous comment since it's not relevant.

lhajouji
lhajouji reviewed Jan 2, 2025
View reviewed changes
Copy link

@lhajouji lhajouji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than updating the date, the article is excellent !

sftim
sftim reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we go for publication on January 14th @fsmunoz? You'll need to update both PRs.

lhajouji
lhajouji approved these changes Jan 2, 2025
View reviewed changes
Copy link

@lhajouji lhajouji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kaslin
Copy link
Contributor

kaslin commented Jan 10, 2025

@fsmunoz reminder to update this if you want to take that Jan 14th publish date!

@fsmunoz
Copy link
Contributor Author

fsmunoz commented Jan 17, 2025

@sftim I wasnt quick enough for January 14th; I have changed both PRs to January 21st, hopefully it' also adequate?

@sftim
Copy link
Contributor

sftim commented Jan 17, 2025

/lgtm
/approve

Will unhold shortly.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsmunoz, lhajouji, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@sftim
Copy link
Contributor

sftim commented Jan 17, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5529f91 into kubernetes:master Jan 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArvindParekh ArvindParekh ArvindParekh left review comments

@sftim sftim sftim left review comments

@lhajouji lhajouji lhajouji approved these changes

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@kikisdeliveryservice kikisdeliveryservice

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Contribex Comms Status
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a SIG Architecture - Enhancements spotlight article
7 participants
@fsmunoz @sftim @kikisdeliveryservice @lhajouji @kaslin @k8s-ci-robot @ArvindParekh