-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubectl-finalize plugin #4326
base: master
Are you sure you want to change the base?
Conversation
🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖 Thanks for submitting your kubectl plugin to Krew! In the meanwhile, here are a few tips to make your plugin manifest better:
Thanks for your patience! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: teocns The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @teocns! |
FYI I noticed you're doing https://github.com/teocns/kubectl-finalize/blob/019a6e5b2809c28cd65fcd2a4997d828a2d02c47/pkg/rm/force_delete.go#L150-L160 Did you know you can use cli-runtime and avoid all that stuff? https://speakerdeck.com/alp/building-kubectl-plugins-like-a-pro I have a recording of this deck available as well. I think you can rewrite your project to use a dynamic client for all these things. Let me know if you wanna spend more time on it and support all resources generically. |
Add kubectl-finalize plugin to help force delete stuck Kubernetes resources