-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose job controller's workqueue rate limiting configs #674
base: master
Are you sure you want to change the base?
Expose job controller's workqueue rate limiting configs #674
Conversation
Signed-off-by: Rotem Elad <[email protected]>
Signed-off-by: Rotem Elad <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Confirmed the defaults for the new flags match the previous default limit and burst, shouldn't change behavior.
I'm not involved anymore so I'm probably not the right person to be reviewing this. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlsorensen, rongou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: Rotem Elad <[email protected]>
New changes are detected. LGTM label has been removed. |
@rongou, @alculquicondor re-generated since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution.
Could you rebase on the master branch to take the CI issue fix patch?
…o roteme-runai/mpi-controller-rate-limits
Issue:
The
mpi-operator
does not handle a large number of MPI jobs effectively. Specifically, when creating a significant number of jobs (e.g., 100), the operator experiences delays in job management, leading to the following issues:CleanPodPolicy
) due to the lag in status updates.Root Cause:
The controller uses a workqueue with a default rate limiter configuration that is not adjustable via operator options. This is in contrast to other load-related configurations (e.g.,
threadiness
,qps
, etc.), which are user-configurable. The low default rate-limiting settings result in insufficient parallel processing, thereby delaying job handling.Proposed Solution:
To address this, I propose exposing the controller's rate-limiting settings as user-configurable options. This change would allow users to adjust the rate limiter based on their specific usage requirements, expected scale, and system capabilities.
The solution has been tested and verified in a production environment and has demonstrated improved handling of bigger-scale MPI jobs.
Backporting Request:
If this fix is approved, I kindly request its inclusion in a new release, ideally in versions from v0.6 onward.
Thank you for your time!