Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kubernetes to v1.31.3 #2478

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Electronic-Waste
Copy link
Member

@Electronic-Waste Electronic-Waste commented Jan 11, 2025

What this PR does / why we need it:

  • Kubernetes upgrade to v1.31.3
  • Minikube upgrade to v1.34.0 in CI
  • Remove deprecated grpc.Dial and replace it with grpc.NewClient

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2457

Checklist:

  • Docs included if any changes are user facing

/cc @kubeflow/wg-automl-leads @helenxie-bit @tariq-hasan

@google-oss-prow google-oss-prow bot requested review from a team and helenxie-bit January 11, 2025 07:07
Copy link

@Electronic-Waste: GitHub didn't allow me to request PR reviews from the following users: tariq-hasan.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:

  • Kubernetes upgrade to v1.31.3
  • Minikube upgrade to v1.34.0 in CI

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2457

Checklist:

  • Docs included if any changes are user facing

/cc @kubeflow/wg-automl-leads @helenxie-bit @tariq-hasan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Electronic-Waste
Copy link
Member Author

Error in CI: https://github.com/kubeflow/katib/actions/runs/12722327561/job/35466233718?pr=2478

Error: pkg/common/v1beta1/katib_manager_util.go:49:15: SA1019: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
	conn, err := grpc.Dial(addr, grpc.WithTransportCredentials(insecure.NewCredentials()))
	             ^
Error: cmd/metricscollector/v1beta1/file-metricscollector/main.go:314:17: SA1019: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
			conn, err := grpc.Dial(*earlyStopServiceAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
			             ^
Error: cmd/metricscollector/v1beta1/file-metricscollector/main.go:436:15: SA1019: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
	conn, err := grpc.Dial(*dbManagerServiceAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
	             ^
make: *** [Makefile:38: lint] Error 1
Error: Process completed with exit code 2.

We also need to re-implement grpc-related logic.

@Electronic-Waste
Copy link
Member Author

This PR has been ready for review now!

PTAL if you have time👀 @kubeflow/wg-automl-leads @helenxie-bit @tariq-hasan

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update @Electronic-Waste!
/lgtm
/assign @kubeflow/wg-training-leads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Kubernetes v1.28 - v1.31
2 participants