-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to use manager's latexTypesetter if window.MathJax is not defined #3847
Conversation
👈 Launch a binder notebook on branch bollwyvl/ipywidgets/gh-3829-lab4-mathjax |
The updated binder log:
|
Will look at the docs fails on a separate PR. |
Had a look at some of the docs stuff... it looks like a good amount of webpack-5-and-requirejs5 stuff... never really worked in the 8.x line. So while potentially related, it's probably not particularly relevant to this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc tests failure seems unrelated. Visual regressions tests all pass. Let's merge and revisit if this needs tweaking.
References
4.0.x
Backport of MathJax double init/font URL fix and binder/log updates jupyterlab/jupyterlab#152314.1.x
Fix MathJax font override, avoid double initialization jupyterlab/jupyterlab#15230Code Changes
(widget_manager as any)._rendermime?.latexTypesetter
ifwindow.MathJax
is not defiendjupyterlab 4.0.7
,notebook 7.0.5
, andnbclassic
to binderjupyter nbclassic-extension
to dev-installset -x
to dev-install for clearer debuggingUser-facing Changes
nbclassic
/ Notebook 6 will still see math (but apparently still has some race conditions)Alternatives
utils.typeset
typeset?
to theIWidgetManager
interfaceutils.typeset
worktext/ipython-gfm
, but that's a whole other storyutils
as aexport default const
instead of individualexport function
, and monkeypatch in jupyterlab-managerModule
like overloading agetter
IWidgetExport
issues