Learn peer reflexive candidates from all STUN reqs #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows ice4j to learn peer reflexive candidates from all STUN
requests, even if it will respond with a 487 Role Conflict. This allows
peer reflexive candidates to be learned sooner, instead of waiting for
conflict resolution to finish before learning the candidate.
This is necessary for interop with buggy peers that do not switch roles
when they receives the Role Conflict error. Chrome 46.0.2490.86 (current
version) appears to have this problem, which this patch alleviates.
I've looked at the relevant section of the spec (RFC 5244 section
7.2.1), and it appears that this behavior is not prohibited.