Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tuple for m2m_models #1438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use tuple for m2m_models #1438

wants to merge 1 commit into from
+3 −2

Conversation

martimarkov
Copy link

Changes how the m2m_models is defined.

Description

Uses a tuple containing the object name and the field.

Related Issue

#1435

Motivation and Context

Ensures that there are no clashes when the m2m relationship is in a parent model and there are multiple child models.

How Has This Been Tested?

Ran all the tests in the suite and no issues came up.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martimarkov