Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated DF (patched) to Dec-4 #52

Draft
wants to merge 6 commits into
base: base-dec-4
Choose a base branch
from
Draft

Updated DF (patched) to Dec-4 #52

wants to merge 6 commits into from

Conversation

wiedld
Copy link
Collaborator

@wiedld wiedld commented Jan 8, 2025 •
edited
Loading

This takes us up to Dec-4 SHA c510ab4

It advances DF by adding these Nov-20 to Dec-4 commits: a2811fc...influxdata:arrow-datafusion:c510ab46fcb1148052bb8999e423360b4c17ecdf

Change in patches:

Removed 5 patches:

  • Screenshot 2025-01-08 at 9 33 50 AM

Add 1 patch (which will fall off with next DF upgrade):

  • Screenshot 2025-01-08 at 9 32 27 AM

Patches applied:

  • Patches already fixed in future upstream commits:

  • Patches still not fixed:

  • Patches specific to our DF branch (no need for upstream fix):

    • we are keeping in the warn logging for the schema mismatch. (Upstream only returns error, or not, based on schema misalignment): our patch 69d6118

@github-actions github-actions bot added documentation Improvements or additions to documentation sqllogictest core physical-expr common labels Jan 8, 2025
alamb and others added 6 commits January 7, 2025 18:56
@alamb @wiedld
Test + workaround for SanityCheck plan
11578a8
@wiedld
test: update new test which is part of Nov 20th upgrade, because the …
7a4fee3 
…SanityCheck plan patch (to turn it off) makes the output result sort nondeterministic
@wiedld
fix: handle when the left side of the union has no fields (e.g. an em…
18186c6 
…pty projection)
@wiedld
chore: default=true for skip_physical_aggregate_schema_check, and add…
4f19005 
… warn logging
@wiedld
Revert "Account for constant equivalence properties in union, tests (a…
598caff 
…pache#12562)"

This reverts commit 577e4bb.
@findepi @wiedld
Increase minimum supported Rust version (MSRV) to 1.80.1 (apache#13667)
6911e00 
* Increase minimum supported Rust version (MSRV) to 1.80.1

We currently require 1.80, but we also say that

> If a hotfix is released for the minimum supported Rust version (MSRV),
> the MSRV will be the minor version with all hotfixes

therefore we should requite 1.80.1 and thus allow dependencies that
require 1.80.1 (such as substrait)

* Revert "fix: cargo msrv check failed (apache#13654)"

This reverts commit c510ab4.
@alamb
Copy link
Collaborator

alamb commented Jan 8, 2025

I'm not sure when we can stop skipping the SanityCheckPlan. I'm unclear how it relates to the additional sort pushdown fixes, including a recent fix done 3 weeks ago

As I understand it, the idea is we will catch up with updates and then once that is completed, we will work on removing our patches. I am actively working on

It sounds like there may be some additional work for the other patches as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
common core development-process documentation Improvements or additions to documentation physical-expr proto sqllogictest substrait
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wiedld @alamb @findepi