Combined EIP-7623 and spec test Spike #8117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
…dCalculator Signed-off-by: Daniel Lehrner <[email protected]> fix MainnetTransactionProcessorTest Signed-off-by: Daniel Lehrner <[email protected]> add test for FrontierRefundCalculator Signed-off-by: Daniel Lehrner <[email protected]> add test for FrontierRefundCalculator Signed-off-by: Daniel Lehrner <[email protected]> add PragueRefundCalculator dummy Signed-off-by: Daniel Lehrner <[email protected]>
8 tasks
Signed-off-by: Simon Dudley <[email protected]>
…erenceTests Signed-off-by: Simon Dudley <[email protected]>
…ec-tests Signed-off-by: Simon Dudley <[email protected]> comment Signed-off-by: Simon Dudley <[email protected]> Allow zero chainId Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]> Use BonsaiReferenceTestWorldState correctly Collect trielog rolling exceptions and display upon state root mismatch Tidy up assertions and world state logging Signed-off-by: Simon Dudley <[email protected]>
siladu
force-pushed
the
eip-7623-update
branch
from
73207db to
f8822a4
Compare
|
In-flight PRs got merged to main and am in the process of adding this code to #8093 so don't need this PR anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Contents
Spike of 7623 fixes + pectra-devnet-5 execution spec test fixes
Based on #8093 (EIP-7623 impl)
Squashed and cherry-picked the following in-flight PRs:
#8106 (Refund Calculator)
#8116 (Spec test authorizationList parsing fix)
#8099 (Spec test world state logging)
Switched in the the devnet5 reference tests
1f04c58(so can be run with./gradlew ethereum:referenceTests:referenceTests- it is expected some are still failing)Remaining 7623 fixes updates are all in this commit:
9bbd356(#8117)Testing
Net result is only 282 execution-spec-test
state_testsare failing including some for 7623, however they are probably 7702 related. I am confident enough with the EIP-7623 implementation that we can get it on main, and tweak from there if necessary.Next Steps
So order of events to get 7623 in I believe is:
git cherry-pick 9bbd356a03d31efb29470fc9c992458cad9361ee