add workflow to verify artifacts #8056
Conversation
joshuafernandes
force-pushed
the
verify-artifacts
branch
4 times, most recently
from
519da4f to
e334153
Compare
Signed-off-by: Joshua Fernandes <[email protected]>
joshuafernandes
force-pushed
the
verify-artifacts
branch
from
e334153 to
4f233ca
Compare
| "https://hyperledger.jfrog.io/hyperledger/besu-maven/org/hyperledger/besu/evm/VERSION/evm-VERSION-sources.jar", | ||
| "https://hyperledger.jfrog.io/hyperledger/besu-maven/org/hyperledger/besu/internal/enclave/VERSION/enclave-VERSION.module", | ||
| "https://hyperledger.jfrog.io/hyperledger/besu-maven/org/hyperledger/besu/internal/nat/VERSION/nat-VERSION.jar", | ||
| "https://hyperledger.jfrog.io/hyperledger/besu-maven/org/hyperledger/besu/internal/enclave/VERSION/enclave-VERSION.pom", |
There was a problem hiding this comment.
this is a very long list! are there any issues with having so many?
Also some of these are on the deprecated list so within 6 months we will remove - enclave, privacy
prob don't need sources.jar verified for all?
There was a problem hiding this comment.
Aye, that makes sense - no issues per say will take an extra couple of secs per artifact to check.
Do we have a core list of artifacts I can check against?
There was a problem hiding this comment.
Let's go with (based on libs used by teku for compile and testing)
besu/evm
besu/plugin-api
besu/metrics-core
besu/internal/core
besu/internal/config
and for each of those, check the
xyz-VERSION.module
.pom
.jar
eg
"https://hyperledger.jfrog.io/hyperledger/besu-maven/org/hyperledger/besu/plugin-api/VERSION/plugin-api-VERSION.module",
"https://hyperledger.jfrog.io/hyperledger/besu-maven/org/hyperledger/besu/plugin-api/VERSION/plugin-api-VERSION.jar",
"https://hyperledger.jfrog.io/hyperledger/besu-maven/org/hyperledger/besu/plugin-api/VERSION/plugin-api-VERSION.pom",
There was a problem hiding this comment.
Done, good for review @macfarla
Signed-off-by: Joshua Fernandes <[email protected]>
…erify-artifacts Signed-off-by: Joshua Fernandes <[email protected]>
joshuafernandes
force-pushed
the
verify-artifacts
branch
from
b80b078 to
1d2e0bc
Compare
| artifacts = [] | ||
| artifacts_base_path = "https://hyperledger.jfrog.io/hyperledger/besu-maven/org/hyperledger/besu" | ||
| # add to this list here to update the list of artifacts to check | ||
| besu_paths = [ |
There was a problem hiding this comment.
@macfarla add to this list here to keep it fresh and it'll check jar, pom and module for each item
| artifacts.append(f"{artifacts_base_path}/{path}.module") | ||
| artifacts.append(f"{artifacts_base_path}/{path}.pom") | ||
| artifacts.append(f"{artifacts_base_path}/{path}.jar") | ||
| return artifacts |
There was a problem hiding this comment.
also verify bom is present
There was a problem hiding this comment.
bom module has .pom and .module eg https://hyperledger.jfrog.io/ui/native/besu-maven/org/hyperledger/besu/bom/24.12.2/
There was a problem hiding this comment.
👍 Done @macfarla. This is now a plain list so easy to edit. Ready for review
Signed-off-by: Joshua Fernandes <[email protected]>
joshuafernandes
changed the title
PR description
Add workflow step to verify artifacts are published and can be downloaded
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.