stm32: fix compilation error when not using uart #2959
+17
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
When not using uart the macro
UART_CLK_ENis most likely also not defined (as it is defined in the board.h alongsideUART_DEV). On some stm32 families (i.e. l0 and f1) this is handled correctly and theUART_CLK_ENmacro is called from the#ifdef UART_DEVsection, but on some families the macro is always called, resulting in a undefined symbol compile error.This pr moves the call to
UART_CLK_ENinto the conditional section for the families with the wrong behaviour. It also only creates theUartHandlevariable when uart is actually in use (more in line with the behaviour of thestm32l0family which I consider to be the best implementation of this conditional compilation part).