Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include more information in spans produced by read consistency round-tripper #10412

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Include more information in spans produced by read consistency round-tripper #10412

wants to merge 2 commits into from
+8 −1

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Jan 13, 2025 •
edited
Loading

What this PR does

This PR expands the information included in trace spans produced by readConsistencyRoundTripper.

readConsistencyRoundTripper will now log:

  • whether the query was evaluated with strong or eventually consistent read consistency
  • the offsets used for each topic

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • [n/a] Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn force-pushed the charleskorn/read-consistency-span branch from 34ef8dc to a172a00 Compare January 13, 2025 02:21
@charleskorn charleskorn marked this pull request as ready for review January 13, 2025 02:59
@charleskorn charleskorn requested a review from a team as a code owner January 13, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhesketh jhesketh jhesketh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskorn @jhesketh