[aiohttp] Fix Broken Fuzzer Build #12931
Merged
+16
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the project build and install steps which were failing when trying to build the `llhttp` parser submodule using a very outdated Nodejs (v.10) provided by the default apt repositories. At the time of this commit, aiohttp 3.11 is using Nodejs 18 in CI for the same task. The changes here upgrade Nodejs to the latest LTS release version available (v22.x) and update the build & install commands to bring them in line with the steps described by the aiohttp contributor documentation and properly build the LLHTTP parser from C & Cython sources.
Prior to this change `aiohttp.BodyPartReader` had been given unexpected arguments (likely reflecting used by older version of the library) which immediately halted the fuzzer by raising a `TypeError`. Updating the arguments resolved the issue.
|
DaveLak is a new contributor to projects/aiohttp. The PR must be approved by known contributors before it can be merged. The past contributors are: manunio |
oliverchang
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.oss-fuzz.com/issues/42532914
The project build & install has been failing since 2024-02-12 when attempting to build the
llhttpparser submodule using a very outdated Nodejs (v10) provided by the default apt repositories. At the time of this commit,aiohttpv3.11 is using Nodejs 18 in CI for the same task.The changes here upgrade Nodejs to the latest LTS release version available (v22.x) and update the build & install commands to bring them in line with the steps described by the aiohttp contributor documentation and properly build the LLHTTP parser from C & Cython sources.