Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:Incorrect boundary checks using output dimensions instead of input dimensions in the implementation of Im2col #7631

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix:Incorrect boundary checks using output dimensions instead of input dimensions in the implementation of Im2col #7631

wants to merge 1 commit into from

Conversation

wewe5215
Copy link
Contributor

Hi XNNPACK developers,
This pull request fixes incorrect boundary checks in the xnn_im2col_conv2d function. Previously, the code compared input_y and input_x against output_height and output_width, causing out-of-bounds accesses (or incorrect zero-padding). The fix changes these checks to use the actual input_height and input_width.

Best regards,
Chi-Wei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wewe5215