split branch into branchCreate and branchRename

gitkraken · Sep 24, 2024 · 3c7adf3 · 3c7adf3
1 parent 446e23b
commit 3c7adf3
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 24 deletions.
diff --git a/src/commands/git/branch.ts b/src/commands/git/branch.ts
@@ -393,12 +393,7 @@ export class BranchGitCommand extends QuickCommand {
 			if (state.flags.includes('--switch')) {
 				await state.repo.switch(state.reference.ref, { createBranch: state.name });
 			} else {
-				await state.repo.branch({
-					create: {
-						name: state.name,
-						startRef: state.reference.ref,
-					},
-				});
+				await state.repo.branchCreate(state.name, state.reference.ref);
 			}
 		}
 	}
@@ -619,12 +614,7 @@ export class BranchGitCommand extends QuickCommand {
 			state.flags = result;
 
 			endSteps(state);
-			await state.repo.branch({
-				rename: {
-					old: state.reference.ref,
-					new: state.name,
-				},
-			});
+			await state.repo.branchRename(state.reference.ref, state.name);
 		}
 	}
 

diff --git a/src/env/node/git/localGitProvider.ts b/src/env/node/git/localGitProvider.ts
@@ -1229,13 +1229,12 @@ export class LocalGitProvider implements GitProvider, Disposable {
 
 	@log()
 	async branch(repoPath: string, options: GitBranchOptions): Promise<void> {
-		const { create = null, rename = null } = options;
 		try {
-			if (create != null) {
+			if (options?.create != null) {
 				await this.git.branch(repoPath, create.name, create.startRef);
 			}
 
-			if (rename != null) {
+			if (options?.rename != null) {
 				await this.git.branch(repoPath, '-m', rename.new, rename.old);
 			}
 

diff --git a/src/git/models/repository.ts b/src/git/models/repository.ts
@@ -24,13 +24,7 @@ import { basename, normalizePath } from '../../system/path';
 import { sortCompare } from '../../system/string';
 import { executeActionCommand } from '../../system/vscode/command';
 import { configuration } from '../../system/vscode/configuration';
-import type {
-	GitBranchOptions,
-	GitDir,
-	GitProviderDescriptor,
-	GitRepositoryCaches,
-	PagingOptions,
-} from '../gitProvider';
+import type { GitDir, GitProviderDescriptor, GitRepositoryCaches, PagingOptions } from '../gitProvider';
 import type { RemoteProvider } from '../remotes/remoteProvider';
 import type { GitSearch } from '../search';
 import type { BranchSortOptions, GitBranch } from './branch';
@@ -574,8 +568,33 @@ export class Repository implements Disposable {
 	}
 
 	@log()
-	branch(options: GitBranchOptions) {
-		return this.container.git.branch(this.uri, options);
+	branchCreate(name: string, startRef: string): Promise<void> {
+		try {
+			return void this.container.git.branch(this.uri, {
+				create: {
+					name: name,
+					startRef: startRef,
+				},
+			});
+		} catch (ex) {
+			Logger.error(ex);
+			void showGenericErrorMessage('Unable to create branch');
+		}
+	}
+
+	@log()
+	branchRename(oldName: string, newName: string) {
+		try {
+			return void this.container.git.branch(this.uri, {
+				rename: {
+					old: oldName,
+					new: newName,
+				},
+			});
+		} catch (ex) {
+			Logger.error(ex);
+			void showGenericErrorMessage('Unable to rename branch');
+		}
 	}
 
 	@log()