modifies lib exclude, adds example lib include #4563
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
explicitly excludes the `_Libraries` directory, and provides example of adding sub directories back in. Should be used for including custom and third party (non -Beckhoff shipped) libraries, improving maintainability
|
@sagatowski - as original submitter of the TwinCAT3.gitignore, could you comment on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explicitly excludes the
_Librariesdirectory, and provides example of adding sub directories back in. Should be used for including custom and third party (non -Beckhoff shipped) libraries, improving maintainabilityReasons for making this change:
The _Libraries directory was blanket ignored before. If using a project with non-Beckhoff libraries, it can become hard to maintain the project, as sourcing those libraries is challenging. The ignore file was modified to explicitly ignore the _Libraries directory (adding wildcarding to ensure it is expllicitly selected).
A commented out example is provided guiding users on how to include specific library directories.