Merge codeql-go repository into codeql #8631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve performance: join-order AllocationSizeOverflow's source and use `matches` not `regexpFind`
…ns-for-builtin-functions Refactor isVariadic helper functions
Fix incorrect type name in database/sql model
Update dataflow libraries and add support for CSV summary flow
Add missing tests for DatabaseSql function models
Fix change notes
Release preparation for version 2.7.4
Co-authored-by: Owen Mansel-Chan <[email protected]>
…zers Fix sanitization by strings.Replace[All] in go/unsafe-quoting and go/log-injection
…ody" This reverts commit 06f889f.
In future we could try harder to find out whether you're Fprintf'ing to stdout, a file named xyz.log etc, but for now this causes Fprintf'ing to an HTTP writer to be mistaken for log-injection rather than just XSS.
Post-release preparation for codeql-cli-2.7.4
Move change notes to proper location
various automatic patches applied to codeql-go
Release preparation for version 2.7.5
Prior to this (a) Go will attempt to update go.mod/sum anyhow, and (b) the `mod tidy -e` option isn't available.
Run `go mod tidy -e` before building
Post-release preparation for codeql-cli-2.9.2
Update Lua tracing config.
There shouldn't be qhelp files in the ql/test tree. #8631 (comment)
This commit removes special handling of the github/codeql-go repository in the ql-for-ql-dataset_measure.yml and the query-list.yml workflows.
cklin
force-pushed
the
cklin/merge-codeql-go-prep
branch
from
cf7a57d to
097d518
Compare
cklin
force-pushed
the
cklin/merge-codeql-go
branch
from
b6ff2a0 to
7f96319
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /** | ||
| * Gets a child node of this node. | ||
| */ | ||
| AstNode getAChild() { result = getChild(_) } |
Check warning
Code scanning / CodeQL
Using implicit `this`
| /** | ||
| * Gets the number of child nodes of this node. | ||
| */ | ||
| int getNumChild() { result = count(getAChild()) } |
Check warning
Code scanning / CodeQL
Using implicit `this`
| AstNode getUniquelyNumberedChild(int index) { | ||
| result = | ||
| rank[index + 1](AstNode child, string kind, int i | | ||
| child = getChildOfKind(kind, i) |
Check warning
Code scanning / CodeQL
Using implicit `this`
|
|
||
| /** Gets the parent node of this AST node, but without crossing function boundaries. */ | ||
| private AstNode parentInSameFunction() { | ||
| result = getParent() and |
Check warning
Code scanning / CodeQL
Using implicit `this`
| } | ||
|
|
||
| /** Gets the innermost function definition to which this AST node belongs, if any. */ | ||
| FuncDef getEnclosingFunction() { result = getParent().parentInSameFunction*() } |
Check warning
Code scanning / CodeQL
Using implicit `this`
adityasharad
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be merged on 2022-05-23
For background, see announcement github/codeql-go#741
This PR merges the
github/codeql-gorepository intogithub/codeqlunder thegodirectory.The repository merge involves the following steps:
github/codeql-go:mainintogithub/codeqlas a new branch Bgodirectorygithub/codeql:maininto the branch BThe cklin/merge-codeql-go-prep branch contains steps 1–3.
The cklin/merge-codeql-go branch contains steps 1–4.
The following link shows only the commits in step 4, which is the more interesting part:
cklin/merge-codeql-go-prep...cklin/merge-codeql-go