C#: Verify that downloaded .NET CLIs are executable #18570
Merged
+60
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
csharp/dotnet3-integration-test
branch
3 times, most recently
from
ae4f069 to
1c98b29
Compare
hvitved
force-pushed
the
csharp/dotnet3-integration-test
branch
from
1c98b29 to
ac4f82c
Compare
hvitved
changed the title
tamasvajk
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading (older) versions of the .NET CLI, we can sometimes run into issues where the downloaded files are not executable. For example, attempting to run .NET 3 on Ubuntu 24.04 results in this error
The fix suggested by this PR is to extend downloading to also include a verification step, where we check that running
dotnet --infoexits cleanly.